]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 745080: Voting extension causes database deadlocks
authorFrédéric Buclin <LpSolit@gmail.com>
Tue, 17 Apr 2012 00:15:59 +0000 (02:15 +0200)
committerFrédéric Buclin <LpSolit@gmail.com>
Tue, 17 Apr 2012 00:15:59 +0000 (02:15 +0200)
r=glob a=LpSolit

extensions/Voting/Extension.pm

index 6a90176ecd06d7cc594c481b9acf585aa62f82ef..ead81266a603269075f67c898b9cb7206f5d3383 100644 (file)
@@ -486,7 +486,10 @@ sub _page_user {
         }
     }
 
-    $dbh->do('DELETE FROM votes WHERE vote_count <= 0');
+    if ($canedit && $bug) {
+        $dbh->do('DELETE FROM votes WHERE vote_count = 0 AND who = ?',
+                 undef, $who->id);
+    }
     $dbh->bz_commit_transaction();
 
     $vars->{'canedit'} = $canedit;