]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virInterfaceDefParse: Simplify and cleanup
authorTim Wiederhake <twiederh@redhat.com>
Wed, 12 Jan 2022 12:41:39 +0000 (13:41 +0100)
committerTim Wiederhake <twiederh@redhat.com>
Fri, 14 Jan 2022 14:38:50 +0000 (15:38 +0100)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/interface_conf.c

index 6cb219437a266d70a258f7a64b6200df78318106..424650489ce1ba1921e8767c1d2def153dcfee97 100644 (file)
@@ -704,14 +704,13 @@ virInterfaceDefParse(const char *xmlStr,
                      unsigned int flags)
 {
     g_autoptr(xmlDoc) xml = NULL;
-    virInterfaceDef *def = NULL;
 
-    if ((xml = virXMLParse(filename, xmlStr, _("(interface_definition)"), "interface.rng",
-                           flags & VIR_INTERFACE_DEFINE_VALIDATE))) {
-        def = virInterfaceDefParseNode(xml, xmlDocGetRootElement(xml));
-    }
+    xml = virXMLParse(filename, xmlStr, _("(interface_definition)"),
+                      "interface.rng", flags & VIR_INTERFACE_DEFINE_VALIDATE);
+    if (!xml)
+        return NULL;
 
-    return def;
+    return virInterfaceDefParseNode(xml, xmlDocGetRootElement(xml));
 }