]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuxml2argvdata: Adjust maximum NUMA node used
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 7 Mar 2023 15:06:03 +0000 (16:06 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 15 Mar 2023 11:46:28 +0000 (12:46 +0100)
We have couple of qemuxml2argvtest cases where up to 8 NUMA nodes
are assumed. These are used to check whether disjoint ranges of
host-nodes= is generated properly. Without prejudice to the
generality, we can rewrite corresponding XML files to use up to 4
NUMA nodes and still have disjoint ranges.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
tests/qemuxml2argvdata/migrate-numa-unaligned.args
tests/qemuxml2argvdata/migrate-numa-unaligned.xml
tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
tests/qemuxml2argvdata/numatune-memnode.args
tests/qemuxml2argvdata/numatune-memnode.x86_64-5.2.0.args
tests/qemuxml2argvdata/numatune-memnode.x86_64-latest.args
tests/qemuxml2argvdata/numatune-memnode.xml
tests/qemuxml2xmloutdata/numatune-memnode.xml

index 6e961cba840a897e6eb62b9cd26b4a6e34981fae..04d49030651a3c15776f38af4d2fec18d7a52a4c 100644 (file)
@@ -17,9 +17,9 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest/.config \
 -smp 32,sockets=32,cores=1,threads=1 \
 -object memory-backend-ram,id=ram-node0,size=20482048,host-nodes=3,policy=preferred \
 -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
--object memory-backend-ram,id=ram-node1,size=675907584,host-nodes=0-7,policy=bind \
+-object memory-backend-ram,id=ram-node1,size=675907584,host-nodes=0-3,policy=bind \
 -numa node,nodeid=1,cpus=1-27,cpus=29,memdev=ram-node1 \
--object memory-backend-ram,id=ram-node2,size=24578457600,host-nodes=1-2,host-nodes=5,host-nodes=7,policy=bind \
+-object memory-backend-ram,id=ram-node2,size=24578457600,host-nodes=0,host-nodes=2,policy=bind \
 -numa node,nodeid=2,cpus=28,cpus=30-31,memdev=ram-node2 \
 -uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \
 -display none \
index e46b723acb71cb88757bb55668163dfa95fb8bfe..c060852297ff257eadae3fa22c787f2dc2b4fab9 100644 (file)
@@ -6,8 +6,8 @@
   <vcpu placement='static'>32</vcpu>
   <numatune>
     <memnode cellid='0' mode='preferred' nodeset='3'/>
-    <memory mode='strict' nodeset='0-7'/>
-    <memnode cellid='2' mode='strict' nodeset='1-2,5-7,^6'/>
+    <memory mode='strict' nodeset='0-3'/>
+    <memnode cellid='2' mode='strict' nodeset='0-2,^1'/>
   </numatune>
   <os>
     <type arch='x86_64' machine='pc'>hvm</type>
index 012c526460fe6b19c01ddc867437677aae07ce2a..2a640f5501b1f5c9365697db380bcf4f79f15a6f 100644 (file)
@@ -5,9 +5,9 @@
   <currentMemory unit='KiB'>24682468</currentMemory>
   <vcpu placement='static'>32</vcpu>
   <numatune>
-    <memory mode='restrictive' nodeset='0-7'/>
+    <memory mode='restrictive' nodeset='0-3'/>
     <memnode cellid='0' mode='restrictive' nodeset='3'/>
-    <memnode cellid='2' mode='restrictive' nodeset='1-2,5,7'/>
+    <memnode cellid='2' mode='restrictive' nodeset='1-2'/>
   </numatune>
   <os>
     <type arch='x86_64' machine='pc'>hvm</type>
index ab222f53db19decaf654e6c5109b0b8939926bf1..917746a523881089ac2937a80639ab4ffe882ba5 100644 (file)
@@ -17,9 +17,9 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest/.config \
 -smp 32,sockets=32,cores=1,threads=1 \
 -object memory-backend-ram,id=ram-node0,size=20971520,host-nodes=3,policy=preferred \
 -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
--object memory-backend-ram,id=ram-node1,size=676331520,host-nodes=0-7,policy=bind \
+-object memory-backend-ram,id=ram-node1,size=676331520,host-nodes=0-3,policy=bind \
 -numa node,nodeid=1,cpus=1-27,cpus=29,memdev=ram-node1 \
--object memory-backend-ram,id=ram-node2,size=24578621440,host-nodes=1-2,host-nodes=5,host-nodes=7,policy=bind \
+-object memory-backend-ram,id=ram-node2,size=24578621440,host-nodes=0,host-nodes=2,policy=bind \
 -numa node,nodeid=2,cpus=28,cpus=30-31,memdev=ram-node2 \
 -uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \
 -display none \
index 0ef1fbfbcab3cafc2a51c65a2e9095600fb1cbcf..982df0b5692d6fa01338d7fe51fcd600d1440cf3 100644 (file)
@@ -18,9 +18,9 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest/.config \
 -smp 32,sockets=32,cores=1,threads=1 \
 -object memory-backend-ram,id=ram-node0,size=20971520,host-nodes=3,policy=preferred \
 -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
--object memory-backend-ram,id=ram-node1,size=676331520,host-nodes=0-7,policy=bind \
+-object memory-backend-ram,id=ram-node1,size=676331520,host-nodes=0-3,policy=bind \
 -numa node,nodeid=1,cpus=1-27,cpus=29,memdev=ram-node1 \
--object memory-backend-ram,id=ram-node2,size=24578621440,host-nodes=1-2,host-nodes=5,host-nodes=7,policy=bind \
+-object memory-backend-ram,id=ram-node2,size=24578621440,host-nodes=0,host-nodes=2,policy=bind \
 -numa node,nodeid=2,cpus=28,cpus=30-31,memdev=ram-node2 \
 -uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \
 -display none \
index 684586b404e4eb69402520f8a63b930a0a3e69a4..087ddf8629e98501881db0b34f18663271a2a9a5 100644 (file)
@@ -18,9 +18,9 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest/.config \
 -smp 32,sockets=32,cores=1,threads=1 \
 -object '{"qom-type":"memory-backend-ram","id":"ram-node0","size":20971520,"host-nodes":[3],"policy":"preferred"}' \
 -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
--object '{"qom-type":"memory-backend-ram","id":"ram-node1","size":676331520,"host-nodes":[0,1,2,3,4,5,6,7],"policy":"bind"}' \
+-object '{"qom-type":"memory-backend-ram","id":"ram-node1","size":676331520,"host-nodes":[0,1,2,3],"policy":"bind"}' \
 -numa node,nodeid=1,cpus=1-27,cpus=29,memdev=ram-node1 \
--object '{"qom-type":"memory-backend-ram","id":"ram-node2","size":24578621440,"host-nodes":[1,2,5,7],"policy":"bind"}' \
+-object '{"qom-type":"memory-backend-ram","id":"ram-node2","size":24578621440,"host-nodes":[0,2],"policy":"bind"}' \
 -numa node,nodeid=2,cpus=28,cpus=30-31,memdev=ram-node2 \
 -uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \
 -display none \
index dd653c5d3b5368c40c66ebf6f7490439c7d30d90..9640eeb9453e0daaf585c7f4376090748ad64a70 100644 (file)
@@ -6,8 +6,8 @@
   <vcpu placement='static'>32</vcpu>
   <numatune>
     <memnode cellid='0' mode='preferred' nodeset='3'/>
-    <memory mode='strict' nodeset='0-7'/>
-    <memnode cellid='2' mode='strict' nodeset='1-2,5-7,^6'/>
+    <memory mode='strict' nodeset='0-3'/>
+    <memnode cellid='2' mode='strict' nodeset='0-2,^1'/>
   </numatune>
   <os>
     <type arch='x86_64' machine='pc'>hvm</type>
index 104d2e6d4c10a0f284342b9c9beedda7ff7529e7..a117745bfb0fe658724bc4584901661775e007f9 100644 (file)
@@ -5,9 +5,9 @@
   <currentMemory unit='KiB'>24682468</currentMemory>
   <vcpu placement='static'>32</vcpu>
   <numatune>
-    <memory mode='strict' nodeset='0-7'/>
+    <memory mode='strict' nodeset='0-3'/>
     <memnode cellid='0' mode='preferred' nodeset='3'/>
-    <memnode cellid='2' mode='strict' nodeset='1-2,5,7'/>
+    <memnode cellid='2' mode='strict' nodeset='0,2'/>
   </numatune>
   <os>
     <type arch='x86_64' machine='pc'>hvm</type>