tc: red, gred: Notify when using the default value for "bandwidth"

The "bandwidth" parameter is optional, but ensure the user is aware
of its default value, to proactively avoid configuration problems.

Signed-off-by: David Ward <david.ward@ll.mit.edu>

diff --git a/tc/q_gred.c b/tc/q_gred.c
index d876f83fee93b5e0629ecbaaea22e2c99b92d63f..5e0dfcfcace9f4737f7d5350258a5936fa0cba6b 100644 (file)
--- a/tc/q_gred.c
+++ b/tc/q_gred.c
@@ -214,9 +214,6 @@ static int gred_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n
                argc--; argv++;
        }
 
-       if (rate == 0)
-               get_rate(&rate, "10Mbit");
-
        if (!opt.qth_min || !opt.qth_max || !opt.limit || !avpkt ||
            (opt.DP<0)) {
                fprintf(stderr, "Required parameter (min, max, limit, "
@@ -227,6 +224,10 @@ static int gred_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n
                burst = (2 * opt.qth_min + opt.qth_max) / (3 * avpkt);
                fprintf(stderr, "GRED: set burst to %u\n", burst);
        }
+       if (!rate) {
+               get_rate(&rate, "10Mbit");
+               fprintf(stderr, "GRED: set bandwidth to 10Mbit\n");
+       }
        if ((parm = tc_red_eval_ewma(opt.qth_min, burst, avpkt)) < 0) {
                fprintf(stderr, "GRED: failed to calculate EWMA constant.\n");
                return -1;

diff --git a/tc/q_red.c b/tc/q_red.c
index 6555eb2a8f66df83dd5cf285b5f1513eb5d3c3ed..1bf2bd9d8e095ff577d6cad77a8b82362dab0b3d 100644 (file)
--- a/tc/q_red.c
+++ b/tc/q_red.c
@@ -109,9 +109,6 @@ static int red_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nl
                argc--; argv++;
        }
 
-       if (rate == 0)
-               get_rate(&rate, "10Mbit");
-
        if (!opt.limit || !avpkt) {
                fprintf(stderr, "RED: Required parameter (limit, avpkt) is missing\n");
                return -1;
@@ -126,6 +123,10 @@ static int red_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nl
                opt.qth_min = opt.qth_max / 3;
        if (!burst)
                burst = (2 * opt.qth_min + opt.qth_max) / (3 * avpkt);
+       if (!rate) {
+               get_rate(&rate, "10Mbit");
+               fprintf(stderr, "RED: set bandwidth to 10Mbit\n");
+       }
        if ((parm = tc_red_eval_ewma(opt.qth_min, burst, avpkt)) < 0) {
                fprintf(stderr, "RED: failed to calculate EWMA constant.\n");
                return -1;