]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
DPP2: Debug print reason for rejecting reconfiguration
authorJouni Malinen <jouni@codeaurora.org>
Fri, 26 Jun 2020 17:37:30 +0000 (20:37 +0300)
committerJouni Malinen <j@w1.fi>
Fri, 26 Jun 2020 17:37:30 +0000 (20:37 +0300)
This makes it easier to understand why Reconfig Authentication Request
gets ignored.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
wpa_supplicant/dpp_supplicant.c

index 801e372bbe027fd369febaf2d1f8d622e0e51dd4..6e1ff7aa592692b8a690ad6f1d5ee4dbe40920cb 100644 (file)
@@ -2101,17 +2101,29 @@ wpas_dpp_rx_reconfig_auth_req(struct wpa_supplicant *wpa_s, const u8 *src,
        wpa_printf(MSG_DEBUG, "DPP: Reconfig Authentication Request from "
                   MACSTR, MAC2STR(src));
 
-       if (!wpa_s->dpp || wpa_s->dpp_auth ||
-           !wpa_s->dpp_reconfig_announcement || !wpa_s->dpp_reconfig_ssid)
+       if (!wpa_s->dpp)
+               return;
+       if (wpa_s->dpp_auth) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Not ready for reconfiguration - pending authentication exchange in progress");
+               return;
+       }
+       if (!wpa_s->dpp_reconfig_announcement || !wpa_s->dpp_reconfig_ssid) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Not ready for reconfiguration - not requested");
                return;
+       }
        for (ssid = wpa_s->conf->ssid; ssid; ssid = ssid->next) {
                if (ssid == wpa_s->dpp_reconfig_ssid &&
                    ssid->id == wpa_s->dpp_reconfig_ssid_id)
                        break;
        }
        if (!ssid || !ssid->dpp_connector || !ssid->dpp_netaccesskey ||
-           !ssid->dpp_csign)
+           !ssid->dpp_csign) {
+               wpa_printf(MSG_DEBUG,
+                          "DPP: Not ready for reconfiguration - no matching network profile with Connector found");
                return;
+       }
 
        auth = dpp_reconfig_auth_req_rx(wpa_s->dpp, wpa_s, ssid->dpp_connector,
                                        ssid->dpp_netaccesskey,