]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: avoid maybe-uninitialized warning by GCC 10
authorBoris Fiuczynski <fiuczy@linux.ibm.com>
Thu, 13 Aug 2020 14:03:44 +0000 (16:03 +0200)
committerErik Skultety <eskultet@redhat.com>
Mon, 17 Aug 2020 06:25:28 +0000 (08:25 +0200)
GCC 10 complains about "well_formed_uri" may be used uninitialzed.
Even though it is a false positive, we can easily avoid it.

Avoiding
  ../src/qemu/qemu_migration.c: In function ‘qemuMigrationDstPrepareDirect’:
  ../src/qemu/qemu_migration.c:2920:16: error: ‘well_formed_uri’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    2920 |             if (well_formed_uri) {
         |                ^

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_migration.c

index 0f2f92b211df5df42cd96581fb7dfb2c75319d14..142faa2cf997b866b4b660a69e9edd680d0085f4 100644 (file)
@@ -2886,7 +2886,7 @@ qemuMigrationDstPrepareDirect(virQEMUDriverPtr driver,
 
         *uri_out = g_strdup_printf(incFormat, "tcp", hostname, port);
     } else {
-        bool well_formed_uri;
+        bool well_formed_uri = false;
 
         if (!(uri = qemuMigrationAnyParseURI(uri_in, &well_formed_uri)))
             goto cleanup;