]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Input: ep93xx_keypad - fix handling of platform_get_irq() error
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 16 Sep 2020 00:51:05 +0000 (17:51 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:08:09 +0000 (10:08 +0100)
[ Upstream commit 7d50f6656dacf085a00beeedbc48b19a37d17881 ]

platform_get_irq() returns -ERRNO on error.  In such case comparison
to 0 would pass the check.

Fixes: 60214f058f44 ("Input: ep93xx_keypad - update driver to new core support")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200828145744.3636-1-krzk@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/input/keyboard/ep93xx_keypad.c

index 7c70492d9d6b5b7c53911b2cc6f376a988890c12..f831f01501d58c991fba95fa3fe354c6207b2aaa 100644 (file)
@@ -250,8 +250,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
        }
 
        keypad->irq = platform_get_irq(pdev, 0);
-       if (!keypad->irq) {
-               err = -ENXIO;
+       if (keypad->irq < 0) {
+               err = keypad->irq;
                goto failed_free;
        }