(no commit message)

diff --git a/lib/sqlalchemy/attributes.py b/lib/sqlalchemy/attributes.py
index 4dcf77f0f6811aaa2e056909855e47dfa26c9bfe..97d54e174be646b4a6562631ece67ccd840495f4 100644 (file)
--- a/lib/sqlalchemy/attributes.py
+++ b/lib/sqlalchemy/attributes.py
@@ -152,14 +152,14 @@ class CallableProp(object):
         if not self.uselist:
             m = self.manager
             self.getattr()
-            return m.attribute_history[self.obj][self.key]
+            return m.attribute_history(self.obj)[self.key]
         else:
             if not self.obj.__dict__.has_key(self.key) or len(self.obj.__dict__[self.key]) == 0:
                 value = self.callable_()
             else:
                 value = None
             p = self.manager.create_list(self.obj, self.key, value, **self.kwargs)
-            self.manager.attribute_history[self.obj][self.key] = p
+            self.manager.attribute_history(self.obj)[self.key] = p
             self.manager = None
             return p
 
@@ -169,7 +169,7 @@ class CallableProp(object):
             self.obj.__dict__[self.key] = value
 
         p = PropHistory(self.obj, self.key, **self.kwargs)
-        self.manager.attribute_history[self.obj][self.key] = p
+        self.manager.attribute_history(self.obj)[self.key] = p
         self.manager = None
         return p
 
@@ -177,11 +177,12 @@ class CallableProp(object):
         pass
     def rollback(self):
         pass
-        
+
+            
 class AttributeManager(object):
     """maintains a set of per-attribute callable/history manager objects for a set of objects."""
     def __init__(self):
-        self.attribute_history = {}
+        pass
 
     def value_changed(self, obj, key, value):
         pass
@@ -215,79 +216,58 @@ class AttributeManager(object):
         self.value_changed(obj, key, None)
 
     def set_callable(self, obj, key, func, uselist, **kwargs):
-        try:
-            d = self.attribute_history[obj]
-        except KeyError, e:
-            d = {}
-            self.attribute_history[obj] = d
-        d[key] = CallableProp(self, func, obj, key, uselist, **kwargs)
+        self.attribute_history(obj)[key] = CallableProp(self, func, obj, key, uselist, **kwargs)
         
     def delete_list_attribute(self, obj, key, **kwargs):
         pass
         
-    def rollback(self, obj = None):
-        if obj is None:
-            for attr in self.attribute_history.values():
-                for hist in attr.values():
-                    hist.rollback()
-        else:
+    def rollback(self, *obj):
+        for o in obj:
             try:
-                attributes = self.attribute_history[obj]
+                attributes = self.attribute_history(o)
                 for hist in attributes.values():
                     hist.rollback()
             except KeyError:
                 pass
 
-    def commit(self, obj = None):
-        if obj is None:
-            for attr in self.attribute_history.values():
-                for hist in attr.values():
-                    hist.commit()
-        else:
+    def commit(self, *obj):
+        for o in obj:
             try:
-                attributes = self.attribute_history[obj]
+                attributes = self.attribute_history(o)
                 for hist in attributes.values():
                     hist.commit()
             except KeyError:
                 pass
                 
     def remove(self, obj):
-        try:
-            del self.attribute_history[obj]
-        except KeyError:
-            pass
+        pass
             
     def get_history(self, obj, key, **kwargs):
         try:
-            return self.attribute_history[obj][key].gethistory(**kwargs)
+            return self.attribute_history(obj)[key].gethistory(**kwargs)
         except KeyError, e:
-            if e.args[0] is obj:
-                d = {}
-                self.attribute_history[obj] = d
-                p = PropHistory(obj, key, **kwargs)
-                d[key] = p
-                return p
-            else:
-                p = PropHistory(obj, key, **kwargs)
-                self.attribute_history[obj][key] = p
-                return p
+            p = PropHistory(obj, key, **kwargs)
+            self.attribute_history(obj)[key] = p
+            return p
 
     def get_list_history(self, obj, key, passive = False, **kwargs):
         try:
-            return self.attribute_history[obj][key].gethistory(passive)
+            return self.attribute_history(obj)[key].gethistory(passive)
         except KeyError, e:
             # TODO: when an callable is re-set on an existing list element
             list_ = obj.__dict__.get(key, None)
-            if e.args[0] is obj:
-                d = {}
-                self.attribute_history[obj] = d
-                p = self.create_list(obj, key, list_, **kwargs)
-                d[key] = p
-                return p
-            else:
-                p = self.create_list(obj, key, list_, **kwargs)
-                self.attribute_history[obj][key] = p
-                return p
+            p = self.create_list(obj, key, list_, **kwargs)
+            self.attribute_history(obj)[key] = p
+            return p
 
+    def attribute_history(self, obj):
+        try:
+            attr = obj.__dict__['_managed_attributes']
+        except KeyError:
+            attr = {}
+            obj.__dict__['_managed_attributes'] = attr
+        return attr
+        
     def register_attribute(self, class_, key, uselist, **kwargs):
         setattr(class_, key, self.create_prop(key, uselist, **kwargs))
+

diff --git a/lib/sqlalchemy/objectstore.py b/lib/sqlalchemy/objectstore.py
index 9600fba04a290aea2a8ae2e994cebb35ed74418a..7cc9a69fb7f377105e5427dc2ef6914d0acd6e2a 100644 (file)
--- a/lib/sqlalchemy/objectstore.py
+++ b/lib/sqlalchemy/objectstore.py
@@ -68,10 +68,6 @@ def delete(*obj):
 def has_key(key):
     return uow().identity_map.has_key(key)
 
-class UOWSmartProperty(attributes.SmartProperty):
-    def attribute_registry(self):
-        return global_attributes
-    
 class UOWListElement(attributes.ListElement):
     def __init__(self, obj, key, data=None, deleteremoved=False):
         attributes.ListElement.__init__(self, obj, key, data=data)
@@ -88,9 +84,7 @@ class UOWListElement(attributes.ListElement):
             
 class UOWAttributeManager(attributes.AttributeManager):
     def __init__(self):
-        # TODO: cleanup the double indirection between UOWSmartProperty, UnitOfWork, and UOWAttributeManager
         attributes.AttributeManager.__init__(self)
-        #self.uow = uow
         
     def value_changed(self, obj, key, value):
         if hasattr(obj, '_instance_key'):
@@ -98,9 +92,6 @@ class UOWAttributeManager(attributes.AttributeManager):
         else:
             uow().register_new(obj)
 
-    def create_prop(self, key, uselist, **kwargs):
-        return UOWSmartProperty(self).property(key, uselist, **kwargs)
-
     def create_list(self, obj, key, list_, **kwargs):
         return UOWListElement(obj, key, list_, **kwargs)
         
@@ -143,6 +134,7 @@ class UnitOfWork(object):
             del self.new[obj]
         except KeyError:
             pass
+        self.attributes.commit(obj)
         self.attributes.remove(obj)
         
     def update(self, obj):
@@ -167,6 +159,7 @@ class UnitOfWork(object):
         except KeyError:
             pass
         self._put(obj._instance_key, obj)
+        self.attributes.commit(obj)
         
     def register_new(self, obj):
         self.new.append(obj)
@@ -237,7 +230,6 @@ class UnitOfWork(object):
             e.commit()
             
         commit_context.post_exec()
-        self.attributes.commit()
         
         if self.parent:
             uow.set(self.parent)
@@ -250,7 +242,8 @@ class UnitOfWork(object):
             raise "UOW transaction is not begun"
         # TODO: locate only objects that are dirty/new/deleted in this UOW,
         # roll only those back.
-        self.attributes.rollback()
+        for obj in self.deleted + self.dirty + self.new:
+            self.attributes.rollback(obj)
         uow.set(self.parent)
             
 class UOWTransaction(object):
@@ -323,6 +316,7 @@ class UOWTransaction(object):
 
         for obj in self.saved_lists:
             try:
+                obj.commit()
                 del self.uow.modified_lists[obj]
             except KeyError:
                 pass
@@ -332,6 +326,7 @@ class UOWTransaction(object):
         
         for obj in self.deleted_lists:
             try:
+                obj.commit()
                 del self.uow.modified_lists[obj]
             except KeyError:
                 pass
@@ -579,7 +574,8 @@ def mapper(*args, **params):
 
 def object_mapper(obj):
     return sqlalchemy.mapper.object_mapper(obj)
-                    
+
+
 global_attributes = UOWAttributeManager()
 uow = util.ScopedRegistry(lambda: UnitOfWork(), "thread")