]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Resolve Coverity RESOURCE_LEAK
authorJohn Ferlan <jferlan@redhat.com>
Tue, 10 Mar 2015 22:24:49 +0000 (18:24 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 11 Mar 2015 17:02:07 +0000 (13:02 -0400)
Commit id 'c9027d8f' added parsing of the CapNet for offload SRIOV NIC
discovery, but forgot to free the nodes

src/conf/node_device_conf.c

index f9c9b6fa7abecd7c77b505cc404db1ffcccaf903..07cc0d02fde4b7ef960d6f186a05d439f99ff087 100644 (file)
@@ -939,7 +939,7 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt,
     xmlNodePtr orignode, lnk;
     size_t i = -1;
     int ret = -1, n = -1;
-    char *tmp;
+    char *tmp = NULL;
     xmlNodePtr *nodes = NULL;
 
     orignode = ctxt->node;
@@ -978,6 +978,7 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt,
             goto out;
         }
         ignore_value(virBitmapSetBit(data->net.features, val));
+        VIR_FREE(tmp);
     }
 
     data->net.subtype = VIR_NODE_DEV_CAP_NET_LAST;
@@ -1002,6 +1003,8 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt,
     ret = 0;
  out:
     ctxt->node = orignode;
+    VIR_FREE(nodes);
+    VIR_FREE(tmp);
     return ret;
 }