]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_snapshot: create: drop update_current variable
authorPavel Hrdina <phrdina@redhat.com>
Wed, 29 Sep 2021 17:02:39 +0000 (19:02 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Wed, 1 Dec 2021 11:33:36 +0000 (12:33 +0100)
There is no need for the extra variable as it is used only at one place.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_snapshot.c

index f0bddea803df0c6f2fa519736a3ed695282d7b4f..980c6e855ea30d0a008779556642f1c1e6f58ce6 100644 (file)
@@ -1702,7 +1702,6 @@ qemuSnapshotCreateXML(virDomainPtr domain,
     virQEMUDriver *driver = domain->conn->privateData;
     virDomainMomentObj *snap = NULL;
     virDomainSnapshotPtr snapshot = NULL;
-    bool update_current = true;
     bool redefine = flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE;
     g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
     g_autoptr(virDomainSnapshotDef) def = NULL;
@@ -1725,10 +1724,6 @@ qemuSnapshotCreateXML(virDomainPtr domain,
                             VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE,
                             NULL);
 
-    if ((redefine && !(flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT)) ||
-        (flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA))
-        update_current = false;
-
     if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0)
         return NULL;
 
@@ -1823,7 +1818,7 @@ qemuSnapshotCreateXML(virDomainPtr domain,
 
  endjob:
     if (snapshot && !(flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)) {
-        if (update_current)
+        if (!redefine || (flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT))
             qemuSnapshotSetCurrent(vm, snap);
 
         if (qemuDomainSnapshotWriteMetadata(vm, snap,