codegen: Initialize internal temp-variables used as reference parameter

When casting Variant to multi-dimensional arrays the length fields are
used as out-parameters and needs to be initialized. They are not guaranteed
to be all set in _variant_get*() in this case.

Fixes tests with -Werror=maybe-uninitialized

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index adafcaa4e71771a9e9a8a8cbd2dcc3153e6099f7..973634d02a5555328091cdee42d00f2009599dc3 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -5187,7 +5187,8 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                var ccall = new CCodeFunctionCall (new CCodeIdentifier (variant_func));
                ccall.add_argument (get_cvalue_ (variant));
 
-               var result = create_temp_value (to, false, node);
+               var needs_init = (to is ArrayType);
+               var result = create_temp_value (to, needs_init, node);
 
                var cfunc = new CCodeFunction (variant_func);
                cfunc.modifiers = CCodeModifiers.STATIC;