- Add comment documentation.

diff --git a/doc/Changelog b/doc/Changelog
index f5861eb983225bc013f79213ff40b30114b6c97d..9f4f412655e2df9127d10d16de5e8b5175bf2b74 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -4,6 +4,7 @@
        - For #391: use struct timeval* start_time for callback information.
        - For #391: fix indentation.
        - For #391: more double casts in python start time calculation.
+       - Add comment documentation.
 
 6 January 2021: Wouter
        - Fix #379: zone loading over HTTP appears to have buffer issues.

diff --git a/services/mesh.c b/services/mesh.c
index 270ffb8bac9a2ed3d43964f59d77edfcab5e5416..27de47eefabf5c429ceb05513415464cc673d8a2 100644 (file)
--- a/services/mesh.c
+++ b/services/mesh.c
@@ -1112,6 +1112,8 @@ int mesh_state_attachment(struct mesh_state* super, struct mesh_state* sub)
  * @param rcode: if not 0, error code.
  * @param rep: reply to send (or NULL if rcode is set).
  * @param r: callback entry
+ * @param start_time: the time to pass to callback functions, it is 0 or
+ *     a value from one of the packets if the mesh state had packets.
  */
 static void
 mesh_do_callback(struct mesh_state* m, int rcode, struct reply_info* rep,

diff --git a/util/data/msgreply.h b/util/data/msgreply.h
index 76b75ea8a54b593a35b4b4322721886fe7fb402e..c6b220ed8d719951ea55dcaabaf70ff31b37d114 100644 (file)
--- a/util/data/msgreply.h
+++ b/util/data/msgreply.h
@@ -554,6 +554,8 @@ struct edns_option* edns_opt_list_find(struct edns_option* list, uint16_t code);
  * @param edns: edns data of the reply.
  * @param repinfo: comm_reply. Reply information for a communication point.
  * @param region: region to store data.
+ * @param start_time: the start time of recursion, when the packet arrived,
+ *     or the current time for cache responses.
  * @return false on failure (a callback function returned an error).
  */
 int inplace_cb_reply_call(struct module_env* env, struct query_info* qinfo,
@@ -572,6 +574,8 @@ int inplace_cb_reply_call(struct module_env* env, struct query_info* qinfo,
  * @param edns: edns data of the reply. Edns input can be found here.
  * @param repinfo: comm_reply. Reply information for a communication point.
  * @param region: region to store data.
+ * @param start_time: the start time of recursion, when the packet arrived,
+ *     or the current time for cache responses.
  * @return false on failure (a callback function returned an error).
  */
 int inplace_cb_reply_cache_call(struct module_env* env,
@@ -591,6 +595,8 @@ int inplace_cb_reply_cache_call(struct module_env* env,
  * @param edns: edns data of the reply. Edns input can be found here.
  * @param repinfo: comm_reply. Reply information for a communication point.
  * @param region: region to store data.
+ * @param start_time: the start time of recursion, when the packet arrived,
+ *     or the current time for cache responses.
  * @return false on failure (a callback function returned an error).
  */
 int inplace_cb_reply_local_call(struct module_env* env,
@@ -611,6 +617,8 @@ int inplace_cb_reply_local_call(struct module_env* env,
  *     is NULL.
  * @param repinfo: comm_reply. Reply information for a communication point.
  * @param region: region to store data.
+ * @param start_time: the start time of recursion, when the packet arrived,
+ *     or the current time for cache responses.
  * @return false on failure (a callback function returned an error).
  */
 int inplace_cb_reply_servfail_call(struct module_env* env,