]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: palmas: Move fixed assignments to 'pinctrl_desc' definition
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 11 Jun 2025 06:13:45 +0000 (08:13 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 18 Jun 2025 11:26:37 +0000 (13:26 +0200)
Assign 'struct pinctrl_desc' .pins and .npins members in definition to
make clear that number of pins is fixed and have less code in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/20250611-pinctrl-const-desc-v2-13-b11c1d650384@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-palmas.c

index 9e272f9deb4f8c49f91d2f09c2c100018a7617f8..d69f114e46426c345d9ffe7567a326eecdd91bb5 100644 (file)
@@ -956,6 +956,8 @@ static struct pinctrl_desc palmas_pinctrl_desc = {
        .pmxops = &palmas_pinmux_ops,
        .confops = &palmas_pinconf_ops,
        .owner = THIS_MODULE,
+       .pins = palmas_pins_desc,
+       .npins = ARRAY_SIZE(palmas_pins_desc),
 };
 
 struct palmas_pinctrl_data {
@@ -1023,8 +1025,6 @@ static int palmas_pinctrl_probe(struct platform_device *pdev)
        }
 
        palmas_pinctrl_desc.name = dev_name(&pdev->dev);
-       palmas_pinctrl_desc.pins = palmas_pins_desc;
-       palmas_pinctrl_desc.npins = ARRAY_SIZE(palmas_pins_desc);
        pci->pctl = devm_pinctrl_register(&pdev->dev, &palmas_pinctrl_desc,
                                          pci);
        if (IS_ERR(pci->pctl)) {