]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
ipa/111245 - bogus modref analysis for store in call that might throw
authorRichard Biener <rguenther@suse.de>
Fri, 28 Feb 2025 10:44:26 +0000 (11:44 +0100)
committerRichard Biener <rguenth@gcc.gnu.org>
Wed, 2 Apr 2025 12:00:17 +0000 (14:00 +0200)
We currently record a kill for

  *x_4(D) = always_throws ();

because we consider the store always executing since the appropriate
check for whether the stmt could throw is guarded by
!cfun->can_throw_non_call_exceptions.

PR ipa/111245
* ipa-modref.cc (modref_access_analysis::analyze_store): Do
not guard the check of whether the stmt could throw by
cfun->can_throw_non_call_exceptions.

* g++.dg/torture/pr111245.C: New testcase.

(cherry picked from commit e6037af6d5e5a43c437257580d75bc8b35a6dcfd)

gcc/ipa-modref.cc
gcc/testsuite/g++.dg/torture/pr111245.C [new file with mode: 0644]

index 400a8856de2d13f0387ab4a5a09f05221b3be599..b38bb7cf449d4d290e88d995ea3ea4cb4c5920a3 100644 (file)
@@ -1747,8 +1747,7 @@ modref_access_analysis::analyze_store (gimple *stmt, tree, tree op, void *data)
     t->record_access_lto (t->m_summary_lto->stores, &r, a);
   if (t->m_always_executed
       && a.useful_for_kill_p ()
-      && (!cfun->can_throw_non_call_exceptions
-         || !stmt_could_throw_p (cfun, stmt)))
+      && !stmt_could_throw_p (cfun, stmt))
     {
       if (dump_file)
        fprintf (dump_file, "   - Recording kill\n");
diff --git a/gcc/testsuite/g++.dg/torture/pr111245.C b/gcc/testsuite/g++.dg/torture/pr111245.C
new file mode 100644 (file)
index 0000000..785f4a5
--- /dev/null
@@ -0,0 +1,23 @@
+/* { dg-do run } */
+
+struct Int {
+  int value;
+};
+
+__attribute__((noipa)) Int always_throws() { throw 123; }
+
+void foo(Int &x) {
+  try {
+    x = always_throws();
+  } catch (...) {
+  }
+}
+
+int main()
+{
+  Int x;
+  x.value = 5;
+  foo(x);
+  if (x.value != 5)
+    __builtin_abort ();
+}