]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: command: re-introduce qemuBuildFSDevCommandLine
authorJán Tomko <jtomko@redhat.com>
Tue, 16 Jul 2019 08:35:44 +0000 (10:35 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 16 Jul 2019 15:00:36 +0000 (17:00 +0200)
This time it only builds one device.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_command.c

index 9d5d54fd6ea5d624f9d6c3c9314e7c4a846a4063..02a6642207de9b989cbff2f111d8799926394573 100644 (file)
@@ -2801,6 +2801,33 @@ qemuBuildFSDevStr(const virDomainDef *def,
 }
 
 
+static int
+qemuBuildFSDevCommandLine(virCommandPtr cmd,
+                          virDomainFSDefPtr fs,
+                          const virDomainDef *def,
+                          virQEMUCapsPtr qemuCaps)
+{
+    char *optstr;
+
+    virCommandAddArg(cmd, "-fsdev");
+    if (!(optstr = qemuBuildFSStr(fs)))
+        return -1;
+    virCommandAddArg(cmd, optstr);
+    VIR_FREE(optstr);
+
+    if (qemuCommandAddExtDevice(cmd, &fs->info) < 0)
+        return -1;
+
+    virCommandAddArg(cmd, "-device");
+    if (!(optstr = qemuBuildFSDevStr(def, fs, qemuCaps)))
+        return -1;
+    virCommandAddArg(cmd, optstr);
+    VIR_FREE(optstr);
+
+    return 0;
+}
+
+
 static int
 qemuBuildFilesystemCommandLine(virCommandPtr cmd,
                                const virDomainDef *def,
@@ -2809,23 +2836,8 @@ qemuBuildFilesystemCommandLine(virCommandPtr cmd,
     size_t i;
 
     for (i = 0; i < def->nfss; i++) {
-        char *optstr;
-        virDomainFSDefPtr fs = def->fss[i];
-
-        virCommandAddArg(cmd, "-fsdev");
-        if (!(optstr = qemuBuildFSStr(fs)))
-            return -1;
-        virCommandAddArg(cmd, optstr);
-        VIR_FREE(optstr);
-
-        if (qemuCommandAddExtDevice(cmd, &fs->info) < 0)
-            return -1;
-
-        virCommandAddArg(cmd, "-device");
-        if (!(optstr = qemuBuildFSDevStr(def, fs, qemuCaps)))
+        if (qemuBuildFSDevCommandLine(cmd, def->fss[i], def, qemuCaps) < 0)
             return -1;
-        virCommandAddArg(cmd, optstr);
-        VIR_FREE(optstr);
     }
 
     return 0;