]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Assume QEMU_CAPS_AES_KEY_WRAP and QEMU_CAPS_DEA_KEY_WRAP for...
authorPeter Krempa <pkrempa@redhat.com>
Tue, 27 Jul 2021 08:41:16 +0000 (10:41 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 21 Sep 2021 10:26:08 +0000 (12:26 +0200)
qemu introduced these options in 2eb1cd0768 ("s390x: CPACF: Handle key
wrap machine options") released in qemu-v2.3.0 but was exposed in
query-command-line-options only in 5bcfa0c543 ("util/qemu-config: fix
missing machine command line options").

The problem is that they are exposed even for architectures which don't
actually in fact support those.

Make the two capabilities a bit more useful by assuming them only on
s390 and thus removing them from other arches.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
33 files changed:
src/qemu/qemu_capabilities.c
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml
tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml
tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml
tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml
tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml

index 9ac8e3b8ba03b918ae7a8b3a99698d420232571d..c9d56c5ad53fa01956d9c5a6105163a93ea81d03 100644 (file)
@@ -3209,8 +3209,6 @@ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
     { "fsdev", "multidevs", QEMU_CAPS_FSDEV_MULTIDEVS },
     { "fsdev", "fmode", QEMU_CAPS_FSDEV_CREATEMODE }, /* Could have also checked fsdev->dmode */
     { "fw_cfg", "file", QEMU_CAPS_FW_CFG },
-    { "machine", "aes-key-wrap", QEMU_CAPS_AES_KEY_WRAP },
-    { "machine", "dea-key-wrap", QEMU_CAPS_DEA_KEY_WRAP },
     { "machine", "kernel_irqchip", QEMU_CAPS_MACHINE_KERNEL_IRQCHIP },
     { "machine", "loadparm", QEMU_CAPS_LOADPARM },
     { "numa", NULL, QEMU_CAPS_NUMA }, /* not needed after qemuCaps->version < 3000000 */
@@ -5002,6 +5000,12 @@ virQEMUCapsInitQMPBasicArch(virQEMUCaps *qemuCaps)
         virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT);
         break;
 
+    case VIR_ARCH_S390:
+    case VIR_ARCH_S390X:
+        virQEMUCapsSet(qemuCaps, QEMU_CAPS_AES_KEY_WRAP);
+        virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEA_KEY_WRAP);
+        break;
+
     case VIR_ARCH_ALPHA:
     case VIR_ARCH_PPC:
     case VIR_ARCH_PPCEMB:
@@ -5009,8 +5013,6 @@ virQEMUCapsInitQMPBasicArch(virQEMUCaps *qemuCaps)
     case VIR_ARCH_SH4EB:
     case VIR_ARCH_RISCV32:
     case VIR_ARCH_RISCV64:
-    case VIR_ARCH_S390:
-    case VIR_ARCH_S390X:
     case VIR_ARCH_SPARC:
     case VIR_ARCH_SPARC64:
     case VIR_ARCH_ARMV6L:
index 0eefa61e1c298bb0d50c41733fd8004a503579bc..62326b50d7e5342d6a0ea016a5bc622823cdba2c 100644 (file)
@@ -82,8 +82,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 2317a70ee6dcd4ca9306b657d800585196580860..32059002f44e5fde4f9929c32b507c9ddb57fae5 100644 (file)
@@ -59,8 +59,6 @@
   <flag name='migrate-rdma'/>
   <flag name='ivshmem'/>
   <flag name='VGA.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index ed5a8297d43c99426097c86079cfc4c7dc2232d2..24b2f1779e01d828820f403a932c73b799c2ff8c 100644 (file)
@@ -59,8 +59,6 @@
   <flag name='ivshmem'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='rtl8139'/>
index 39c1f41e34b4c994a6a115ddfd0f7d69cde7b40f..f410a1b57a7cbda241868efda4c7d4d33e54e65d 100644 (file)
@@ -82,8 +82,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 3b09d49d160d36486206d944c1379579cc9f2c0a..51496f4f0b05bc7f86703ecbe378fdd3b9fb5d7b 100644 (file)
@@ -58,8 +58,6 @@
   <flag name='ivshmem'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='rtl8139'/>
index 15b63bb26e9f0bf7831c51654edd9a95301fcc57..6c976825d81d1463a12568b93574653d8c1eb38c 100644 (file)
@@ -26,8 +26,6 @@
   <flag name='memory-backend-file'/>
   <flag name='iothread'/>
   <flag name='migrate-rdma'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='migration-event'/>
   <flag name='virtio-net'/>
   <flag name='incoming-defer'/>
index eb4416ab29860891bc851521ba067377a6629b3b..1eebed01002ea0f582995998e493c65d62c86e8c 100644 (file)
@@ -26,8 +26,6 @@
   <flag name='memory-backend-file'/>
   <flag name='iothread'/>
   <flag name='migrate-rdma'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='migration-event'/>
   <flag name='virtio-net'/>
   <flag name='incoming-defer'/>
index 5427b008b9693ccaca83a53e325cd5f903a2a4c7..adfc101766ac9338e49dfa4580700d7cecb914c7 100644 (file)
@@ -81,8 +81,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 849473a4f2eacb3bf3e54f77b58c8627b530bd25..2c8a9620d659ab17e8a78d58cf2ba98e6b54dc08 100644 (file)
@@ -59,8 +59,6 @@
   <flag name='ivshmem'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='rtl8139'/>
index 63a17e848d564b986cfb75eaec1ce458e53de907..ca796c0b18638bbcd3f41df6f051e44051d8d435 100644 (file)
@@ -81,8 +81,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 38ab21d32af2de1cadb0cc35a022b916e879b587..d16b6f12e2a41333bdff3a10ab09ad76aaf8bd8b 100644 (file)
@@ -61,8 +61,6 @@
   <flag name='migrate-rdma'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index 47798dbc0b9afd70f678373ab77e296af95cc5a1..263781cf0f712d685fc4dd940d78d24b6416270a 100644 (file)
@@ -61,8 +61,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 820a5101536101f004a87099a0bf0b844454644c..eb661dcc43cb68baf9c1c70c5d468769a816277a 100644 (file)
@@ -65,8 +65,6 @@
   <flag name='migrate-rdma'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index 293fbdfc66167fe66c550decc72f19ee8836eeca..e47593c1da711af27474a2fc3c0921473e9ee928 100644 (file)
@@ -65,8 +65,6 @@
   <flag name='migrate-rdma'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index a2acbf96296a39b539be1755ef6ae4516300cd39..a5936fb94e7fdcc5bb7add741f80a4c01aaa18e3 100644 (file)
@@ -80,8 +80,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index e6a73cef1250b1bd657b0230a28dd9738c62542f..758318d811c8366b9ac57d12c3d39cc9f66e24e1 100644 (file)
@@ -80,8 +80,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index ca5cc1329f624bcf25c4b5d82358504e27b0286a..10bf3a86c2ff78161d9ba485853c05daf10929d9 100644 (file)
@@ -62,8 +62,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index 3ea3055859b0489b8f395bbd894b254db9634150..e109e6c713cb844afbe58402076cde6c08b615f5 100644 (file)
@@ -61,8 +61,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 9f555464692f40c57db0c230090808f6fd1c99c4..3dec056865151a8e22fa2b90d112ab1c7d26ca5f 100644 (file)
@@ -81,8 +81,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 7e6389123eebea8f93924fc6f53cae85fbed6b5b..7c665a911210804c38ea325b56691256ebde621a 100644 (file)
@@ -64,8 +64,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index 7118745ada650b91eb57b8f1b5a17ab9ad4bdd45..6d7326d901d2d052fcbeb41d47f76cb52798573e 100644 (file)
@@ -62,8 +62,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 8b61261f7fffb2a685f5184d9404518320577d8a..497b9ee2385a5bf0f5dddbec5cf965d546126102 100644 (file)
@@ -65,8 +65,6 @@
   <flag name='migrate-rdma'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index 0d2ef61be623f7273f6ac4bbfe92e0aed4762a47..3346831157805fcace17a8751f7bb4e2841d2c77 100644 (file)
@@ -81,8 +81,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 603cf7735dfc3cf4ce36224318da484edad6f44a..eb60861eaf3a656bb1c87f658bf821848e15f263 100644 (file)
@@ -26,8 +26,6 @@
   <flag name='memory-backend-file'/>
   <flag name='iothread'/>
   <flag name='migrate-rdma'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='migration-event'/>
   <flag name='incoming-defer'/>
   <flag name='chardev-file-append'/>
index 17f2bd9c258b7acefff09ffa516eecef8e4dc811..050bcefc8182ece822b8a7f1962de854133f01d1 100644 (file)
@@ -81,8 +81,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 687a0e76116de70dc0f15cd2f03fbd483a64eab7..084499a5157417782c6281b369cd28bb3a045be2 100644 (file)
@@ -63,8 +63,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index e986a071505b9c3d0cc9be83d002bf0ea79e9c08..dc9b6c84826afbdc6566d3f30d7d5fbce85f3df3 100644 (file)
@@ -61,8 +61,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='ioh3420'/>
index 77a3a5d0ec5b591355f553c9c367bf06b0303e9a..eb6212a7ee1bcd7254fc112cc1106c7a168b0af9 100644 (file)
@@ -64,8 +64,6 @@
   <flag name='migrate-rdma'/>
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index 31fd94ce3159b5cf028001f98a5cafd448852626..b7c175285b53364f6fa3b7c9c9c5c44cfbfc9b9f 100644 (file)
@@ -80,8 +80,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index e7226a92fb0917b8f05d8b33bb48275c8d02fe21..548218368cd8445aa2fc422c2f8dc4410b4660bd 100644 (file)
@@ -62,8 +62,6 @@
   <flag name='VGA.vgamem_mb'/>
   <flag name='vmware-svga.vgamem_mb'/>
   <flag name='pc-dimm'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='aarch64-off'/>
   <flag name='migration-event'/>
index f7af5bb2350c7be07ae9c3d5e9db613ad632ff8e..9da8a17888025acd83de75bf0af737c46f1c5298 100644 (file)
@@ -79,8 +79,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>
index 346da4f795088297c984b0bbc311791fcce731fa..9a2f2a34b6fe27a1b382946bab3a1ec192615f9d 100644 (file)
@@ -79,8 +79,6 @@
   <flag name='qxl.vgamem_mb'/>
   <flag name='pc-dimm'/>
   <flag name='machine-vmport-opt'/>
-  <flag name='aes-key-wrap'/>
-  <flag name='dea-key-wrap'/>
   <flag name='pci-serial'/>
   <flag name='migration-event'/>
   <flag name='gpex-pcihost'/>