]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal/drivers/spear: Fix error condition for reading st,thermal-flags
authorGopi Krishna Menon <krishnagopi487@gmail.com>
Fri, 27 Mar 2026 09:05:24 +0000 (14:35 +0530)
committerDaniel Lezcano <daniel.lezcano@kernel.org>
Fri, 27 Mar 2026 10:26:43 +0000 (11:26 +0100)
of_property_read_u32 returns 0 on success. The current check returns
-EINVAL if the property is read successfully.

Fix the check by removing ! from of_property_read_u32

Fixes: b9c7aff481f1 ("drivers/thermal/spear_thermal.c: add Device Tree probing capability")
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://patch.msgid.link/20260327090526.59330-1-krishnagopi487@gmail.com
drivers/thermal/spear_thermal.c

index 603dadcd3df5833988e9cb0a6ab57f8348fdd9a8..5e3e9c1f32f8ebdf08e01b5c954c7ab2403e8577 100644 (file)
@@ -93,7 +93,7 @@ static int spear_thermal_probe(struct platform_device *pdev)
        struct device_node *np = pdev->dev.of_node;
        int ret = 0, val;
 
-       if (!np || !of_property_read_u32(np, "st,thermal-flags", &val)) {
+       if (!np || of_property_read_u32(np, "st,thermal-flags", &val)) {
                dev_err(&pdev->dev, "Failed: DT Pdata not passed\n");
                return -EINVAL;
        }