]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Copy to octets is not a strdup
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Thu, 30 Oct 2014 15:06:22 +0000 (11:06 -0400)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Thu, 30 Oct 2014 15:06:34 +0000 (11:06 -0400)
src/lib/value.c

index 1bcbf6d6d5707fdb783e36d52ed2f83f3450939c..c70dea576352fc532e63361f0fbd2ad1ce49c890 100644 (file)
@@ -536,9 +536,9 @@ ssize_t value_data_from_str(TALLOC_CTX *ctx, value_data_t *out,
                 *      No 0x prefix, just copy verbatim.
                 */
                if ((len < 2) || (strncasecmp(value, "0x", 2) != 0)) {
-                       out->octets = talloc_memdup(ctx, (uint8_t const *)value, len + 1);
+                       out->octets = talloc_memdup(ctx, (uint8_t const *)value, len);
                        talloc_set_type(out->octets, uint8_t);
-                       ret = len + 1;
+                       ret = len;
                        goto finish;
                }