BUG/MEDIUM: cache/cli: make "show cache" thread-safe

The "show cache" command restarts from the previous node to look for a
duplicate key, but does this after having released the lock, so under
high write load, the node has many chances of having been reassigned
and the dereference of the node crashes after a few iterations. Since
the keys are unique anyway, there's no point looking for a dup, so
let's just continue from the next value.

This is only marked as medium as it seems to have been there for a
while, and discovering it that late simply means that nobody uses that
command, thus in practice it has a very limited impact on real users.

This should be backported to all stable versions.

diff --git a/src/cache.c b/src/cache.c
index 287ff5325bef8c347dadfeba661e22487816b434..6ac23b27cedf4ca694f37cc54a6e6bf07877ed03 100644 (file)
--- a/src/cache.c
+++ b/src/cache.c
@@ -2589,7 +2589,7 @@ static int cli_io_handler_show_cache(struct appctx *appctx)
                while (1) {
 
                        shctx_lock(shctx_ptr(cache));
-                       if (!node || (node = eb32_next_dup(node)) == NULL)
+                       if (!node)
                                node = eb32_lookup_ge(&cache->entries, next_key);
                        if (!node) {
                                shctx_unlock(shctx_ptr(cache));