conf: do not check union on wrong net type

This will obviously not work.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index a77b3df9e138d7e9b2d7aee89f95fa0a57387908..8a11ff345984020a894b1fc35422d6d1ac1571b4 100644 (file)
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -3049,27 +3049,6 @@ int lxc_create_network(struct lxc_handler *handler)
 
                netdev = iterator->elem;
 
-               if (netdev->type != LXC_NET_MACVLAN && netdev->priv.macvlan_attr.mode) {
-                       ERROR("Invalid macvlan.mode for a non-macvlan netdev");
-                       return -1;
-               }
-
-               if (netdev->type != LXC_NET_VETH && netdev->priv.veth_attr.pair) {
-                       ERROR("Invalid veth pair for a non-veth netdev");
-                       return -1;
-               }
-
-               if (netdev->type != LXC_NET_VLAN && netdev->priv.vlan_attr.vid > 0) {
-                       ERROR("Invalid vlan.id for a non-macvlan netdev");
-                       return -1;
-               }
-
-               if (netdev->type < 0 || netdev->type > LXC_NET_MAXCONFTYPE) {
-                       ERROR("invalid network configuration type '%d'",
-                             netdev->type);
-                       return -1;
-               }
-
                if (netdev_conf[netdev->type](handler, netdev)) {
                        ERROR("failed to create netdev");
                        return -1;
@@ -3114,9 +3093,9 @@ bool lxc_delete_network(struct lxc_handler *handler)
                if (ret < 0)
                        WARN("Failed to deconfigure network device");
 
-               /* Recent kernel remove the virtual interfaces when the network
+               /* Recent kernels remove the virtual interfaces when the network
                 * namespace is destroyed but in case we did not move the
-                * interface to the network namespace, we have to destroy it
+                * interface to the network namespace, we have to destroy it.
                 */
                ret = lxc_netdev_delete_by_index(netdev->ifindex);
                if (-ret == ENODEV) {