]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: pac1934: Fix clamped value in pac1934_reg_snapshot
authorThorsten Blum <thorsten.blum@linux.dev>
Tue, 2 Dec 2025 18:13:06 +0000 (19:13 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 21 Dec 2025 11:14:10 +0000 (11:14 +0000)
The local variable 'curr_energy' was never clamped to
PAC_193X_MIN_POWER_ACC or PAC_193X_MAX_POWER_ACC because the return
value of clamp() was not used. Fix this by assigning the clamped value
back to 'curr_energy'.

Cc: stable@vger.kernel.org
Fixes: 0fb528c8255b ("iio: adc: adding support for PAC193x")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/pac1934.c

index ec96bb0f2ed60cd771a86f4870d520c3958007d7..712b5e9caba6df03647ec5b8341bcc8f5bb3d3d7 100644 (file)
@@ -665,9 +665,9 @@ static int pac1934_reg_snapshot(struct pac1934_chip_info *info,
                        /* add the power_acc field */
                        curr_energy += inc;
 
-                       clamp(curr_energy, PAC_193X_MIN_POWER_ACC, PAC_193X_MAX_POWER_ACC);
-
-                       reg_data->energy_sec_acc[cnt] = curr_energy;
+                       reg_data->energy_sec_acc[cnt] = clamp(curr_energy,
+                                                             PAC_193X_MIN_POWER_ACC,
+                                                             PAC_193X_MAX_POWER_ACC);
                }
 
                offset_reg_data_p += PAC1934_VPOWER_ACC_REG_LEN;