re PR middle-end/60729 (Compiler failure for combination of -ftrapv and -O3: compiler...

2014-04-02  Richard Biener  <rguenther@suse.de>

	PR middle-end/60729
	* optabs.c (expand_abs_nojump): Honor flag_trapv only for
	MODE_INTs.  Properly use negv_optab.
	(expand_abs): Likewise.

	* g++.dg/vect/pr60729.cc: New testcase.

From-SVN: r209012

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 8a4de8639ac2a72c2f11a6f660d62be43be3ed7f..cf26a4128b61281ee25a40e6714b83b95e8385b6 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2014-04-02  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/60729
+       * optabs.c (expand_abs_nojump): Honor flag_trapv only for
+       MODE_INTs.  Properly use negv_optab.
+       (expand_abs): Likewise.
+
 2014-04-02  Richard Biener  <rguenther@suse.de>
 
        PR bootstrap/60719

diff --git a/gcc/optabs.c b/gcc/optabs.c
index c4540f8856ceff75b21e5617dbc4cad1aeec4848..54f07ab02b9a26a9ac7cdd1e80f279aa77cbd427 100644 (file)
--- a/gcc/optabs.c
+++ b/gcc/optabs.c
@@ -3384,7 +3384,8 @@ expand_abs_nojump (enum machine_mode mode, rtx op0, rtx target,
 {
   rtx temp;
 
-  if (! flag_trapv)
+  if (GET_MODE_CLASS (mode) != MODE_INT
+      || ! flag_trapv)
     result_unsignedp = 1;
 
   /* First try to do it with a special abs instruction.  */
@@ -3407,7 +3408,8 @@ expand_abs_nojump (enum machine_mode mode, rtx op0, rtx target,
     {
       rtx last = get_last_insn ();
 
-      temp = expand_unop (mode, neg_optab, op0, NULL_RTX, 0);
+      temp = expand_unop (mode, result_unsignedp ? neg_optab : negv_optab,
+                         op0, NULL_RTX, 0);
       if (temp != 0)
        temp = expand_binop (mode, smax_optab, op0, temp, target, 0,
                             OPTAB_WIDEN);
@@ -3449,7 +3451,8 @@ expand_abs (enum machine_mode mode, rtx op0, rtx target,
 {
   rtx temp, op1;
 
-  if (! flag_trapv)
+  if (GET_MODE_CLASS (mode) != MODE_INT
+      || ! flag_trapv)
     result_unsignedp = 1;
 
   temp = expand_abs_nojump (mode, op0, target, result_unsignedp);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 7092fa705493a1ddb1f0f6c4e3ade5a53aef5095..5e3bc26c8e30cc2d1a14e872281c9e33f833f534 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-04-02  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/60729
+       * g++.dg/vect/pr60729.cc: New testcase.
+
 2014-04-01  Fabien Chêne  <fabien@gcc.gnu.org>
 
         * g++.dg/init/ctor4.C: Adjust.

diff --git a/gcc/testsuite/g++.dg/vect/pr60729.cc b/gcc/testsuite/g++.dg/vect/pr60729.cc
new file mode 100644 (file)
index 0000000..fd472c5
--- /dev/null
+++ b/gcc/testsuite/g++.dg/vect/pr60729.cc
@@ -0,0 +1,10 @@
+// { dg-do compile }
+// { dg-additional-options "-ftrapv" }
+
+void doSomething(int dim, double *Y, double *A) 
+{
+  for (int k=0; k<dim; k++) 
+    Y[k] += __builtin_fabs (A[k]);
+}
+
+// { dg-final { cleanup-tree-dump "vect" } }