tcptls: when disabling a server port, we should set the accept_fd to -1.

If we don't set this to -1 if the structure can be potentially re-used
later then it's possible that we'll issue a close() on an unrelated file
descriptor, breaking asterisk in other interesting ways.

I believe this to be an unlikely scenario, but it costs nothing to be
safe.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
(cherry picked from commit 4a637d6d11cb5d7cb98b2ee27a991e2d2eca79c2)

diff --git a/main/tcptls.c b/main/tcptls.c
index dc25cb4047fcc82a262421f185fc052b33820168..e51e70ef0d7cd43656a24c6600b8f3aa5adc376e 100644 (file)
--- a/main/tcptls.c
+++ b/main/tcptls.c
@@ -837,6 +837,7 @@ void ast_tcptls_server_start(struct ast_tcptls_session_args *desc)
 
        if (desc->accept_fd != -1) {
                close(desc->accept_fd);
+               desc->accept_fd = -1;
        }
 
        /* If there's no new server, stop here */