]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: dts: BCM53573: Fix Ethernet info for Luxul devices
authorRafał Miłecki <rafal@milecki.pl>
Thu, 13 Jul 2023 11:11:45 +0000 (13:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:37 +0000 (12:22 +0200)
[ Upstream commit 44ad8207806973f4e4f7d870fff36cc01f494250 ]

Both Luxul's XAP devices (XAP-810 and XAP-1440) are access points that
use a non-default design. They don't include switch but have a single
Ethernet port and BCM54210E PHY connected to the Ethernet controller's
MDIO bus.

Support for those devices regressed due to two changes:

1. Describing MDIO bus with switch
After commit 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125
rev 4 switch") Linux stopped probing for MDIO devices.

2. Dropping hardcoded BCM54210E delays
In commit fea7fda7f50a ("net: phy: broadcom: Fix RGMII delays
configuration for BCM54210E") support for other PHY modes was added but
that requires a proper "phy-mode" value in DT.

Both above changes are correct (they don't need to be reverted or
anything) but they need this fix for DT data to be correct and for Linux
to work properly.

Fixes: 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Link: https://lore.kernel.org/r/20230713111145.14864-1-zajec5@gmail.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts
arch/arm/boot/dts/bcm47189-luxul-xap-810.dts

index 57ca1cfaecd8e8192d4923db24b356bdd0b6359c..00e688b45d9815e2347baf1d3acba601494f1539 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};
index 2e1a7e382cb7a43fe7247267e92b6a561441ad9f..78c80a5d3f4fa0c0a080d303b17728f78968b4e5 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};