]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()
authorDan Carpenter <error27@gmail.com>
Wed, 20 May 2026 06:00:30 +0000 (09:00 +0300)
committerBjorn Andersson <andersson@kernel.org>
Fri, 22 May 2026 02:51:04 +0000 (21:51 -0500)
The devm_memremap() function doesn't return NULL, it returns error
pointers.  Fix the error checking to match.

Fixes: ac23106a9b9a ("soc: qcom: llcc-qcom: get SCT descriptors from fw-populated memory")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/ag1N_rAHEQ1YJsa7@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/llcc-qcom.c

index 1359c7b2d41b41b160871d31c083489beae4b72e..8948b5fd42d2afa528024997f92e47a6ef587122 100644 (file)
@@ -5410,9 +5410,9 @@ static int qcom_llcc_get_fw_config(struct platform_device *pdev)
        }
 
        slc_mem = devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_WB);
-       if (!slc_mem) {
+       if (IS_ERR(slc_mem)) {
                dev_err(dev, "Failed to memremap SLC shared memory\n");
-               return -ENOMEM;
+               return PTR_ERR(slc_mem);
        }
 
        ret = qcom_llcc_verify_fw_config(dev, slc_mem);