pknock: return -ENXIO for problems during init

Some functions like the crypto init or proc_mkdir do not return an
error value. Replace the -1, which is actually EPERM, and looks a
little out of place, and use ENXIO instead. (After all, the requested
objects were not there after the request of initialization.)

diff --git a/extensions/xt_pknock.c b/extensions/xt_pknock.c
index 87653a3ea14ddef505679f2f95bacdff72bb1293..0b0bcf1547b11cf7621f4223396229bb9a687318 100644 (file)
--- a/extensions/xt_pknock.c
+++ b/extensions/xt_pknock.c
@@ -1097,7 +1097,7 @@ static int __init xt_pknock_mt_init(void)
        if (request_module(crypto.algo) < 0) {
                printk(KERN_ERR PKNOCK "request_module('%s') error.\n",
                         crypto.algo);
-               return -1;
+               return -ENXIO;
        }
 
        crypto.tfm = crypto_alloc_hash(crypto.algo, 0, CRYPTO_ALG_ASYNC);
@@ -1105,7 +1105,7 @@ static int __init xt_pknock_mt_init(void)
        if (crypto.tfm == NULL) {
                printk(KERN_ERR PKNOCK "failed to load transform for %s\n", 
                                                crypto.algo);
-               return -1;
+               return -ENXIO;
        }
 
        crypto.size = crypto_hash_digestsize(crypto.tfm);
@@ -1117,7 +1117,7 @@ static int __init xt_pknock_mt_init(void)
 
        if (!(pde = proc_mkdir("xt_pknock", init_net__proc_net))) {
                printk(KERN_ERR PKNOCK "proc_mkdir() error in _init().\n");
-               return -1;
+               return -ENXIO;
        }
        return xt_register_match(&xt_pknock_mt_reg);
 }