]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_namespace: Don't build namespace if domain doesn't have it enabled
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 21 Aug 2020 13:49:29 +0000 (15:49 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 24 Aug 2020 17:19:47 +0000 (19:19 +0200)
Even if namespaces are disabled, then due to a missing check at the
beginning of qemuDomainBuildNamespace(), the domain startup code
still tries to populate (nonexistent) domain's namespace.

Fixes: 8da362fe62766b4eee209cd3ce591ceb62299d13
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_namespace.c

index 797722b7148b85a3df533bde82a5329d4d6631cb..b6724a095f2082c0a8f248d7daac39f6067f0715 100644 (file)
@@ -616,6 +616,11 @@ qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg,
 {
     VIR_AUTOSTRINGLIST paths = NULL;
 
+    if (!qemuDomainNamespaceEnabled(vm, QEMU_DOMAIN_NS_MOUNT)) {
+        VIR_DEBUG("namespaces disabled for domain %s", vm->def->name);
+        return 0;
+    }
+
     if (qemuDomainPopulateDevices(cfg, &paths) < 0)
         return -1;