]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
lxc-debian: don't hardcode valid releases 1880/head
authorAntonio Terceiro <terceiro@debian.org>
Sat, 28 Oct 2017 11:20:35 +0000 (09:20 -0200)
committerAntonio Terceiro <terceiro@debian.org>
Sat, 28 Oct 2017 12:32:12 +0000 (10:32 -0200)
This avoids the dance of updating the list of valid releases every time
Debian makes a new release.

It also fixes the following bug: even though lxc-debian will default to
creating containers of the latest stable by querying the archive, it
won't allow you to explicitly request `stable` because the current list
of valid releases don't include it.

Last, but not least, avoid hitting the mirror in the case the desired
release is one of the ones we know will always be there, i.e. stable,
testing, sid, and unstable.

Signed-off-by: Antonio Terceiro <terceiro@debian.org>
templates/lxc-debian.in

index 4b92328f26a8ba0bdd0764dd753d9fdf41598733..fa87cb95dcb9fd71bd8f3f446ee07625577615f0 100644 (file)
@@ -768,12 +768,13 @@ if [ -n "$authkey" ]; then
     fi
 fi
 
-current_release=$(wget "${MIRROR}/dists/stable/Release" -O - 2> /dev/null | head |awk '/^Codename: (.*)$/ { print $2; }')
-release=${release:-${current_release}}
-valid_releases=('wheezy' 'jessie' 'stretch' 'buster' 'testing' 'sid' 'unstable')
-if [[ ! "${valid_releases[*]}" =~ (^|[^[:alpha:]])$release([^[:alpha:]]|$) ]]; then
-    echo "Invalid release ${release}, valid ones are: ${valid_releases[*]}"
-    exit 1
+release=${release:-stable}
+permanent_releases=('stable' 'testing' 'sid' 'unstable')
+if [[ ! "${permanent_releases[*]}" =~ (^|[^[:alpha:]])$release([^[:alpha:]]|$) ]]; then
+    if ! wget "${MIRROR}/dists/${release}/Release" -O /dev/null 2> /dev/null; then
+       echo "Invalid release ${release} (not found in mirror)"
+       exit 1
+    fi
 fi
 
 # detect rootfs