]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
logging: Don't check the output of virGetUserConfigDirectory()
authorFabiano Fidêncio <fidencio@redhat.com>
Thu, 19 Dec 2019 08:41:45 +0000 (09:41 +0100)
committerFabiano Fidêncio <fidencio@redhat.com>
Fri, 20 Dec 2019 08:38:43 +0000 (09:38 +0100)
virGetUserConfigDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/logging/log_daemon_config.c

index ab42921140a0ee9e7f04fc93daf01541a2e0069b..97f2de90a609fa3652b9f3894e043d1f89c35f83 100644 (file)
@@ -44,16 +44,12 @@ virLogDaemonConfigFilePath(bool privileged, char **configfile)
     } else {
         g_autofree char *configdir = NULL;
 
-        if (!(configdir = virGetUserConfigDirectory()))
-            goto error;
+        configdir = virGetUserConfigDirectory();
 
         *configfile = g_strdup_printf("%s/virtlogd.conf", configdir);
     }
 
     return 0;
-
- error:
-    return -1;
 }