t7101: modernize test path checks

Replace old-style `test -[df]` and `! test -[df]` assertions with
the modern `test_path_is_file`, `test_path_is_dir`, and
`test_path_is_missing` helpers.

These helpers provide more informative error messages in case of
failure (e.g., "File 'foo' is missing" instead of just exit code 1).

While at it, fix a typo and an incorrect path
reference in one of the test descriptions.

Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t7101-reset-empty-subdirs.sh b/t/t7101-reset-empty-subdirs.sh
index 33d5d5b76e7d17b2efa1b2cb426a9f67f513c9b9..d1d3e231fc2eb8cd2d8ca03ca2e4c2756cc61479 100755 (executable)
--- a/t/t7101-reset-empty-subdirs.sh
+++ b/t/t7101-reset-empty-subdirs.sh
@@ -34,32 +34,32 @@ test_expect_success 'resetting tree HEAD^' '
 '
 
 test_expect_success 'checking initial files exist after rewind' '
-       test -d path0 &&
-       test -f path0/COPYING
+       test_path_is_dir path0 &&
+       test_path_is_file path0/COPYING
 '
 
 test_expect_success 'checking lack of path1/path2/COPYING' '
-       ! test -f path1/path2/COPYING
+       test_path_is_missing path1/path2/COPYING
 '
 
 test_expect_success 'checking lack of path1/COPYING' '
-       ! test -f path1/COPYING
+       test_path_is_missing path1/COPYING
 '
 
 test_expect_success 'checking lack of COPYING' '
-       ! test -f COPYING
+       test_path_is_missing COPYING
 '
 
-test_expect_success 'checking checking lack of path1/COPYING-TOO' '
-       ! test -f path0/COPYING-TOO
+test_expect_success 'checking lack of path0/COPYING-TOO' '
+       test_path_is_missing path0/COPYING-TOO
 '
 
 test_expect_success 'checking lack of path1/path2' '
-       ! test -d path1/path2
+       test_path_is_missing path1/path2
 '
 
 test_expect_success 'checking lack of path1' '
-       ! test -d path1
+       test_path_is_missing path1
 '
 
 test_done