]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: Use dma_fence_check_and_signal_locked()
authorPhilipp Stanner <phasta@kernel.org>
Mon, 1 Dec 2025 10:50:08 +0000 (11:50 +0100)
committerPhilipp Stanner <phasta@kernel.org>
Thu, 4 Dec 2025 14:03:40 +0000 (15:03 +0100)
Xe is one of the few users utilizing the return code of
dma_fence_signal() to check whether a fence had already been signaled by
someone else.

To clean up and simplify the dma_fence API, the few kernel users relying
on that behavior shall be ported to an alternative function.

Replace dma_fence_signal_locked() with
dma_fence_check_and_signal_locked().

Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251201105011.19386-6-phasta@kernel.org
drivers/gpu/drm/xe/xe_hw_fence.c

index b2a0c46dfcd4200cf1b444de24c29a3897e22c9a..f6057456e4609345775996419c7bb9e91a1480c3 100644 (file)
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 {
        struct xe_hw_fence *fence, *next;
        unsigned long flags;
-       int err;
        bool tmp;
 
        if (XE_WARN_ON(!list_empty(&irq->pending))) {
@@ -93,9 +92,8 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
                spin_lock_irqsave(&irq->lock, flags);
                list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
                        list_del_init(&fence->irq_link);
-                       err = dma_fence_signal_locked(&fence->dma);
+                       XE_WARN_ON(dma_fence_check_and_signal_locked(&fence->dma));
                        dma_fence_put(&fence->dma);
-                       XE_WARN_ON(err);
                }
                spin_unlock_irqrestore(&irq->lock, flags);
                dma_fence_end_signalling(tmp);