]> git.ipfire.org Git - thirdparty/vuejs/router.git/commitdiff
chore: note about beforeunload
authorEduardo San Martin Morote <posva13@gmail.com>
Tue, 27 Dec 2022 13:00:29 +0000 (14:00 +0100)
committerEduardo San Martin Morote <posva13@gmail.com>
Tue, 27 Dec 2022 13:00:33 +0000 (14:00 +0100)
packages/router/src/history/html5.ts

index bc4531f957c024780ee240d81aa6ba4e85f515ba..6aeda01ac86618d2b1d65be5c2df7ff97d1fd8e8 100644 (file)
@@ -144,7 +144,11 @@ function useHistoryListeners(
 
   // set up the listeners and prepare teardown callbacks
   window.addEventListener('popstate', popStateHandler)
-  window.addEventListener('beforeunload', beforeUnloadListener)
+  // TODO: could we use 'pagehide' or 'visibilitychange' instead?
+  // https://developer.chrome.com/blog/page-lifecycle-api/
+  window.addEventListener('beforeunload', beforeUnloadListener, {
+    passive: true,
+  })
 
   return {
     pauseListeners,