]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
[IPTABLES]: libxt_iprange: Fix IP validation logic
authorJames King <t.james.king@gmail.com>
Tue, 1 Apr 2008 19:17:36 +0000 (21:17 +0200)
committerPatrick McHardy <kaber@trash.net>
Wed, 2 Apr 2008 10:25:33 +0000 (12:25 +0200)
IP address validation logic was inverted, causing valid addresses to
be rejected.

Signed-off-by: James King <t.james.king@gmail.com>
extensions/libxt_iprange.c

index 51b35f8a2718c5fa60e2e5decb3e74c5390b0f7c..c4fe7cfcb0528d83788d1967c1eaeddcc99acd16 100644 (file)
@@ -41,14 +41,14 @@ parse_iprange(char *arg, struct ipt_iprange *range)
                *dash = '\0';
 
        ip = numeric_to_ipaddr(arg);
-       if (ip != NULL)
+       if (!ip)
                exit_error(PARAMETER_PROBLEM, "iprange match: Bad IP address `%s'\n",
                           arg);
        range->min_ip = ip->s_addr;
 
        if (dash != NULL) {
                ip = numeric_to_ipaddr(dash+1);
-               if (ip != NULL)
+               if (!ip)
                        exit_error(PARAMETER_PROBLEM, "iprange match: Bad IP address `%s'\n",
                                   dash+1);
                range->max_ip = ip->s_addr;