]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/v3d: Remove `v3d->cpu_job`
authorMaíra Canal <mcanal@igalia.com>
Mon, 13 Jan 2025 15:47:41 +0000 (12:47 -0300)
committerMaíra Canal <mcanal@igalia.com>
Tue, 14 Jan 2025 18:23:24 +0000 (15:23 -0300)
CPU jobs, like Cache Clean jobs, execute synchronously once the DRM
scheduler starts running them. Consequently, a global `v3d->cpu_job`
variable is unnecessary, as everything is managed within the
`v3d_cpu_job_run()` function.

This commit removes the `v3d->cpu_job` pointer, as it is not needed.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250113154741.67520-2-mcanal@igalia.com
drivers/gpu/drm/v3d/v3d_drv.h
drivers/gpu/drm/v3d/v3d_sched.c

index dc1cfe2e14beb6a826350ab6d9c024379afad2af..9deaefa0f95b71b842f1c5bef2c6a8a8ffc21fe2 100644 (file)
@@ -147,7 +147,6 @@ struct v3d_dev {
        struct v3d_render_job *render_job;
        struct v3d_tfu_job *tfu_job;
        struct v3d_csd_job *csd_job;
-       struct v3d_cpu_job *cpu_job;
 
        struct v3d_queue_state queue[V3D_MAX_QUEUES];
 
index da08ddb01d2120c73b111f43f06fb77f3cda33fc..961465128d8035a84dbc02a02b2acab339245f4c 100644 (file)
@@ -656,8 +656,6 @@ v3d_cpu_job_run(struct drm_sched_job *sched_job)
        struct v3d_cpu_job *job = to_cpu_job(sched_job);
        struct v3d_dev *v3d = job->base.v3d;
 
-       v3d->cpu_job = job;
-
        if (job->job_type >= ARRAY_SIZE(cpu_job_function)) {
                DRM_DEBUG_DRIVER("Unknown CPU job: %d\n", job->job_type);
                return NULL;