Author: Phil Oester <kernel@linuxace.com>

Bug 3115: logging segfaults if access_log is set to a directory

diff --git a/src/logfile.cc b/src/logfile.cc
index 1db6d3985adaa382b864c057be42c6232cb714f5..3c83aae5f7d3a83e14036bca6b31bc0c740efac4 100644 (file)
--- a/src/logfile.cc
+++ b/src/logfile.cc
@@ -128,6 +128,8 @@ logfileOpen(const char *path, size_t bufsz, int fatal_flag)
                        "\tThe parent directory must be writeable by the\n"
                        "\tuser '%s', which is the cache_effective_user\n"
                        "\tset in squid.conf.", path, Config.effectiveUser);
+            } else if (EISDIR == errno && fatal_flag) {
+                fatalf("Cannot open '%s' because it is a directory, not a file.\n", path);
             } else {
                 debugs(50, 1, "logfileOpen: " << path << ": " << xstrerror());
                 return NULL;