Set default_aa on AsyncDnsServer to False by default

In 6e684d44 I mistakenly set the default for `default_aa` for
`AsyncDnsServer()` to `True` and then explicitly set it to True in
cases where all the `ResponseHandlers` said
`yield DnsResponseSend(..., authoritative=True)` as if the default was
`False`.

Also the rest of `AsyncDnsServer` code (namely `_prepare_responses`)
reads like `default_aa` is `False` by default.

This accidentally changed the behavior of servers which don't set the
`default_aa` and where AA is not set from the zone data
(e.g. `dispatch/ans3`).

diff --git a/bin/tests/system/isctest/asyncserver.py b/bin/tests/system/isctest/asyncserver.py
index d2b22d7c129d2b5fdbad2f269d9d426613a07f2b..849dba300a71e8c80bb3f9266cb0e619d85e172b 100644 (file)
--- a/bin/tests/system/isctest/asyncserver.py
+++ b/bin/tests/system/isctest/asyncserver.py
@@ -822,7 +822,7 @@ class AsyncDnsServer(AsyncServer):
         self,
         /,
         default_rcode: dns.rcode.Rcode = dns.rcode.REFUSED,
-        default_aa: bool = True,
+        default_aa: bool = False,
         keyring: Union[
             Dict[dns.name.Name, dns.tsig.Key], None, _NoKeyringType
         ] = _NoKeyringType(),