meson: src: add check-aclrules test

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>

diff --git a/src/Makefile.am b/src/Makefile.am
index fb3c4a837840663e52c5228dcddd8f5a7ca44846..09c1bf884d21e703fe1d66dd9d06bd7cf63e71e4 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -21,7 +21,6 @@
 # that actually use them.
 
 BUILT_SOURCES =
-STATEFUL_DRIVER_SOURCE_FILES =
 augeas_DATA =
 augeastest_DATA =
 if WITH_DTRACE_PROBES
@@ -31,17 +30,7 @@ RPC_PROBE_FILES =
 
 include locking/Makefile.inc.am
 include admin/Makefile.inc.am
-include qemu/Makefile.inc.am
-include bhyve/Makefile.inc.am
-include libxl/Makefile.inc.am
-include vz/Makefile.inc.am
 include lxc/Makefile.inc.am
-include interface/Makefile.inc.am
-include network/Makefile.inc.am
-include nwfilter/Makefile.inc.am
-include node_device/Makefile.inc.am
-include secret/Makefile.inc.am
-include storage/Makefile.inc.am
 
 
 # Keep this list synced with RPC_PROBE_FILES
@@ -98,18 +87,12 @@ else !WITH_REMOTE
 check-protocol:
 endif !WITH_REMOTE
 
-check-aclrules:
-       $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-aclrules.py \
-               $(REMOTE_PROTOCOL) \
-               $(STATEFUL_DRIVER_SOURCE_FILES)
-
 check-aclperms:
        $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-aclperms.py \
                $(srcdir)/access/viraccessperm.h \
                $(srcdir)/access/viraccessperm.c
 
 check-local: check-protocol \
-       check-aclrules \
        check-aclperms check-admin
 .PHONY: check-protocol $(PROTOCOL_STRUCTS:structs=struct)
 

diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am
deleted file mode 100644 (file)
index 7a9c6a8..0000000
--- a/src/bhyve/Makefile.inc.am
+++ /dev/null
@@ -1,3 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += $(addprefix $(srcdir)/,$(BHYVE_DRIVER_SOURCES))

diff --git a/src/bhyve/meson.build b/src/bhyve/meson.build
index dbd4c64cea675c02516886f73a12197f6fef2ef1..643e72680ed4e435f6db7b757e190667e03134a0 100644 (file)
--- a/src/bhyve/meson.build
+++ b/src/bhyve/meson.build
@@ -11,6 +11,7 @@ bhyve_sources = files(
 )
 
 driver_source_files += bhyve_sources
+stateful_driver_source_files += bhyve_sources
 
 if conf.has('WITH_BHYVE')
   bhyve_driver_impl = static_library(

diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am
deleted file mode 100644 (file)
index 6cd6dff..0000000
--- a/src/interface/Makefile.inc.am
+++ /dev/null
@@ -1,4 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(INTERFACE_DRIVER_SOURCES))

diff --git a/src/interface/meson.build b/src/interface/meson.build
index f2dd92cf1a185ac2fc4d3e100fb5bcd47882069f..1092c5a2673b762bcc66c213aea8e06f876803c6 100644 (file)
--- a/src/interface/meson.build
+++ b/src/interface/meson.build
@@ -11,6 +11,7 @@ if conf.has('WITH_UDEV')
 endif
 
 driver_source_files += files(interface_driver_sources)
+stateful_driver_source_files += files(interface_driver_sources)
 
 if conf.has('WITH_INTERFACE')
   virt_modules += {

diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am
deleted file mode 100644 (file)
index d713f4e..0000000
--- a/src/libxl/Makefile.inc.am
+++ /dev/null
@@ -1,3 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += $(addprefix $(srcdir)/,$(LIBXL_DRIVER_SOURCES))

diff --git a/src/libxl/meson.build b/src/libxl/meson.build
index 44b2591ec857d14c5933d148b99613f8ad51ce0d..7afde2f81f0fa0dff9643b3576346c205b54c367 100644 (file)
--- a/src/libxl/meson.build
+++ b/src/libxl/meson.build
@@ -11,6 +11,7 @@ libxl_driver_sources = [
 ]
 
 driver_source_files += files(libxl_driver_sources)
+stateful_driver_source_files += files(libxl_driver_sources)
 
 if conf.has('WITH_LIBXL')
   libxl_driver_imp = static_library(

diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index 6abd08e333e47a17cf08096f2326aa414435cc1f..564b3519bcb425fcf93d1420309be59f865274b3 100644 (file)
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -1,10 +1,5 @@
 # vim: filetype=automake
 
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(LXC_MONITOR_PROTOCOL_GENERATED) \
-       $(LXC_MONITOR_GENERATED) \
-       $(addprefix $(srcdir)/,$(LXC_DRIVER_SOURCES))
-
 if WITH_LXC
 
 if WITH_DTRACE_PROBES

diff --git a/src/lxc/meson.build b/src/lxc/meson.build
index b2954f40a7ecb1bf4bac96032578a251b71d9bef..22c8341fb056ca22ee9f0228f666ccd7688ae9d3 100644 (file)
--- a/src/lxc/meson.build
+++ b/src/lxc/meson.build
@@ -46,6 +46,12 @@ driver_source_files += [
   lxc_monitor_generated,
 ]
 
+stateful_driver_source_files += [
+  files(lxc_driver_sources),
+  lxc_monitor_protocol_generated,
+  lxc_monitor_generated,
+]
+
 lxc_controller_sources = files(
   'lxc_conf.c',
   'lxc_container.c',

diff --git a/src/meson.build b/src/meson.build
index 0a366a8256ac1906459c9c2ef9f404c80c30f188..f2a0ccea228894ea5a4b0527c68fd3761da1b432 100644 (file)
--- a/src/meson.build
+++ b/src/meson.build
@@ -219,6 +219,10 @@ virt_install_dirs = []
 #   driver source files to check
 driver_source_files = []
 
+# stateful_driver_source_files:
+#   stateful driver source files to check
+stateful_driver_source_files = []
+
 
 # list subdirectories
 
@@ -875,3 +879,10 @@ test(
   args: [ check_driverimpls_prog.path(), driver_source_files ],
   env: runutf8,
 )
+
+test(
+  'check-aclrules',
+  python3_prog,
+  args: [ check_aclrules_prog.path(), files('remote/remote_protocol.x'), stateful_driver_source_files ],
+  env: runutf8,
+)

diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am
deleted file mode 100644 (file)
index cf5cff4..0000000
--- a/src/network/Makefile.inc.am
+++ /dev/null
@@ -1,4 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(NETWORK_DRIVER_SOURCES))

diff --git a/src/network/meson.build b/src/network/meson.build
index 7e316c968ef95aa257311dbdfca033e5dacd70d4..2e031e811fc5b01e028559843eacc1da39e7cd0a 100644 (file)
--- a/src/network/meson.build
+++ b/src/network/meson.build
@@ -4,6 +4,7 @@ network_driver_sources = [
 ]
 
 driver_source_files += files(network_driver_sources)
+stateful_driver_source_files += files(network_driver_sources)
 
 network_leases_helper_sources = files(
   'leaseshelper.c',

diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am
deleted file mode 100644 (file)
index ddd906f..0000000
--- a/src/node_device/Makefile.inc.am
+++ /dev/null
@@ -1,5 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(NODE_DEVICE_DRIVER_SOURCES)) \
-       $(NULL)

diff --git a/src/node_device/meson.build b/src/node_device/meson.build
index c14f09a793b30bb57f5a56f60ff609343dd9e464..5953c6b8ed618a6c3a842ddb50368d9c651f8ea8 100644 (file)
--- a/src/node_device/meson.build
+++ b/src/node_device/meson.build
@@ -2,6 +2,8 @@ node_device_driver_sources = [
   'node_device_driver.c',
 ]
 
+stateful_driver_source_files += files(node_device_driver_sources)
+
 if conf.has('WITH_HAL')
   node_device_driver_sources += 'node_device_hal.c'
 endif

diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am
deleted file mode 100644 (file)
index 68bc42c..0000000
--- a/src/nwfilter/Makefile.inc.am
+++ /dev/null
@@ -1,4 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(NWFILTER_DRIVER_SOURCES))

diff --git a/src/nwfilter/meson.build b/src/nwfilter/meson.build
index d4b9cc890b9049a599576bfff1460d664d5bd859..dcdc30f373153c4a018f4da959e6ab420f40edd7 100644 (file)
--- a/src/nwfilter/meson.build
+++ b/src/nwfilter/meson.build
@@ -7,6 +7,7 @@ nwfilter_driver_sources = [
 ]
 
 driver_source_files += files(nwfilter_driver_sources)
+stateful_driver_source_files += files(nwfilter_driver_sources)
 
 if conf.has('WITH_NWFILTER')
   nwfilter_driver_impl = static_library(

diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
deleted file mode 100644 (file)
index 96265d2..0000000
--- a/src/qemu/Makefile.inc.am
+++ /dev/null
@@ -1,3 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += $(addprefix $(srcdir)/,$(QEMU_DRIVER_SOURCES))

diff --git a/src/qemu/meson.build b/src/qemu/meson.build
index 25cf66b97280bae87529d695119f6a0f98128367..644d74479b2517a9e90233ce069daf5c0bef5702 100644 (file)
--- a/src/qemu/meson.build
+++ b/src/qemu/meson.build
@@ -38,6 +38,7 @@ qemu_driver_sources = [
 ]
 
 driver_source_files += files(qemu_driver_sources)
+stateful_driver_source_files += files(qemu_driver_sources)
 
 qemu_dtrace_gen_headers = []
 qemu_dtrace_gen_objects = []

diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am
deleted file mode 100644 (file)
index 3613052..0000000
--- a/src/secret/Makefile.inc.am
+++ /dev/null
@@ -1,4 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(SECRET_DRIVER_SOURCES))

diff --git a/src/secret/meson.build b/src/secret/meson.build
index 4410b781bd401cc7f8c34ddaa7101ca9c84dade0..d576d3218eb24fb70028e08cfd8fd812d1cd8d43 100644 (file)
--- a/src/secret/meson.build
+++ b/src/secret/meson.build
@@ -3,6 +3,7 @@ secret_driver_sources = [
 ]
 
 driver_source_files += files(secret_driver_sources)
+stateful_driver_source_files += files(secret_driver_sources)
 
 if conf.has('WITH_SECRETS')
   virt_modules += {

diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am
deleted file mode 100644 (file)
index 0834ac4..0000000
--- a/src/storage/Makefile.inc.am
+++ /dev/null
@@ -1,4 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += \
-       $(addprefix $(srcdir)/,$(STORAGE_DRIVER_SOURCES))

diff --git a/src/storage/meson.build b/src/storage/meson.build
index 9cb13f2996d04ba3a6cf59ba81aee300a6d5138a..18ea0f3fb512f33b5aebe6ffd396656319b1c062 100644 (file)
--- a/src/storage/meson.build
+++ b/src/storage/meson.build
@@ -9,6 +9,7 @@ storage_driver_sources = [
 ]
 
 driver_source_files += files(storage_driver_sources)
+stateful_driver_source_files += files(storage_driver_sources)
 
 storage_backend_fs_sources = [
   'storage_backend_fs.c',

diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am
deleted file mode 100644 (file)
index eb6721f..0000000
--- a/src/vz/Makefile.inc.am
+++ /dev/null
@@ -1,3 +0,0 @@
-# vim: filetype=automake
-
-STATEFUL_DRIVER_SOURCE_FILES += $(addprefix $(srcdir)/,$(VZ_DRIVER_SOURCES))

diff --git a/src/vz/meson.build b/src/vz/meson.build
index 7101f092c8cd83913805d8954cfe4a28754cb250..2859dc79793a45b2404a23da11582cb6f1526cd4 100644 (file)
--- a/src/vz/meson.build
+++ b/src/vz/meson.build
@@ -5,6 +5,7 @@ vz_driver_sources = [
 ]
 
 driver_source_files += files(vz_driver_sources)
+stateful_driver_source_files += files(vz_driver_sources)
 
 if conf.has('WITH_VZ')
   vz_driver_impl = static_library(