]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
IIO: si7020: Allocate correct amount of memory in devm_iio_device_alloc
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Fri, 13 Feb 2015 07:58:41 +0000 (23:58 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Mar 2015 13:10:58 +0000 (14:10 +0100)
commit e01becbad300712a28f29b666e685536f45e83bc upstream.

Since only a pointer to struct i2c_client is stored in a private area
of IIO device created by the driver there's no need to allocate
sizeof(struct i2c_client) worth of storage.

Pushed to stable as this is linked to the revert patch previously.
Without this followup the original patch looks sensible.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/humidity/si7020.c

index b54164677b898d5c9e5b4b9983fe61271f3c80b5..8e7f9f314fec962e4774ff0ef0ed339639432d01 100644 (file)
@@ -126,7 +126,7 @@ static int si7020_probe(struct i2c_client *client,
        /* Wait the maximum power-up time after software reset. */
        msleep(15);
 
-       indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*client));
+       indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
        if (!indio_dev)
                return -ENOMEM;