non-consuming variant of do_mkdirat()

similar to previous commit; replacement is filename_mkdirat()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index bb526ae9a1d716e1830e84a63853c88988085996..d75b549ed528d137ce8ba90e61faf6c5051af0f3 100644 (file)
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -1343,4 +1343,4 @@ fs/namei.c primitives that consume filesystem references (do_renameat2(),
 do_linkat(), do_symlinkat(), do_mkdirat(), do_mknodat(), do_unlinkat()
 and do_rmdir()) are getting replaced with non-consuming analogues
 (filename_renameat2(), etc.)  Replaced so far: do_renameat2(), do_linkat(),
-do_symlinkat().
+do_symlinkat(), do_mkdirat().

diff --git a/fs/init.c b/fs/init.c
index a54ef750ffe3a56ccdc00875e424d519d0d955e2..9a550ba4802f657744cf4396fd3877c0447683a0 100644 (file)
--- a/fs/init.c
+++ b/fs/init.c
@@ -164,7 +164,8 @@ int __init init_unlink(const char *pathname)
 
 int __init init_mkdir(const char *pathname, umode_t mode)
 {
-       return do_mkdirat(AT_FDCWD, getname_kernel(pathname), mode);
+       CLASS(filename_kernel, name)(pathname);
+       return filename_mkdirat(AT_FDCWD, name, mode);
 }
 
 int __init init_rmdir(const char *pathname)

diff --git a/fs/internal.h b/fs/internal.h
index 4a63b89c02d7de3864028cc774024b2fffadbc8e..03638008d84a83257007cc58d5754ab91a98aa59 100644 (file)
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -59,7 +59,7 @@ int do_unlinkat(int dfd, struct filename *name);
 int may_linkat(struct mnt_idmap *idmap, const struct path *link);
 int filename_renameat2(int olddfd, struct filename *oldname, int newdfd,
                 struct filename *newname, unsigned int flags);
-int do_mkdirat(int dfd, struct filename *name, umode_t mode);
+int filename_mkdirat(int dfd, struct filename *name, umode_t mode);
 int do_mknodat(int dfd, struct filename *name, umode_t mode, unsigned int dev);
 int filename_symlinkat(struct filename *from, int newdfd, struct filename *to);
 int filename_linkat(int olddfd, struct filename *old, int newdfd,

diff --git a/fs/namei.c b/fs/namei.c
index c88ad27f66c71b52555be87580834d5c335d4806..21a2dbd8b9e66e3f5c99155522c993859ab77ded 100644 (file)
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -5207,7 +5207,7 @@ err:
 }
 EXPORT_SYMBOL(vfs_mkdir);
 
-int do_mkdirat(int dfd, struct filename *name, umode_t mode)
+int filename_mkdirat(int dfd, struct filename *name, umode_t mode)
 {
        struct dentry *dentry;
        struct path path;
@@ -5217,9 +5217,8 @@ int do_mkdirat(int dfd, struct filename *name, umode_t mode)
 
 retry:
        dentry = filename_create(dfd, name, &path, lookup_flags);
-       error = PTR_ERR(dentry);
        if (IS_ERR(dentry))
-               goto out_putname;
+               return PTR_ERR(dentry);
 
        error = security_path_mkdir(&path, dentry,
                        mode_strip_umask(path.dentry->d_inode, mode));
@@ -5239,19 +5238,19 @@ retry:
                lookup_flags |= LOOKUP_REVAL;
                goto retry;
        }
-out_putname:
-       putname(name);
        return error;
 }
 
 SYSCALL_DEFINE3(mkdirat, int, dfd, const char __user *, pathname, umode_t, mode)
 {
-       return do_mkdirat(dfd, getname(pathname), mode);
+       CLASS(filename, name)(pathname);
+       return filename_mkdirat(dfd, name, mode);
 }
 
 SYSCALL_DEFINE2(mkdir, const char __user *, pathname, umode_t, mode)
 {
-       return do_mkdirat(AT_FDCWD, getname(pathname), mode);
+       CLASS(filename, name)(pathname);
+       return filename_mkdirat(AT_FDCWD, name, mode);
 }
 
 /**

diff --git a/io_uring/fs.c b/io_uring/fs.c
index cd4d88d37795241a948a8c0d5350ebf42633b40e..40541b539e0d7c91a1dae018576d6c0877a9cb02 100644 (file)
--- a/io_uring/fs.c
+++ b/io_uring/fs.c
@@ -182,11 +182,12 @@ int io_mkdirat_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 int io_mkdirat(struct io_kiocb *req, unsigned int issue_flags)
 {
        struct io_mkdir *mkd = io_kiocb_to_cmd(req, struct io_mkdir);
+       CLASS(filename_complete_delayed, name)(&mkd->filename);
        int ret;
 
        WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK);
 
-       ret = do_mkdirat(mkd->dfd, complete_getname(&mkd->filename), mkd->mode);
+       ret = filename_mkdirat(mkd->dfd, name, mkd->mode);
 
        req->flags &= ~REQ_F_NEED_CLEANUP;
        io_req_set_res(req, ret, 0);