]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled()
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tue, 17 Dec 2024 21:41:51 +0000 (23:41 +0200)
committerStephen Boyd <sboyd@kernel.org>
Mon, 23 Dec 2024 20:53:52 +0000 (12:53 -0800)
The helper devm_clk_bulk_get_all_enable() missed to return the number of
clocks stored in the clk_bulk_data table referenced by the clks
argument and, therefore, will be dropped.

Use the newly introduced devm_clk_bulk_get_all_enabled() variant
instead, which is consistent with devm_clk_bulk_get_all() in terms of
the returned value:

 > 0 if one or more clocks have been stored
 = 0 if there are no clocks
 < 0 if an error occurred

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://lore.kernel.org/r/20241217-clk_bulk_ena_fix-v5-1-aafbbb245155@collabora.com
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/soc/mediatek/mtk-pmic-wrap.c

index 9fdc0ef79202618d0bd0188d0bf53152285c6c51..0bcd8582637550c90c1c6df619077b7df7bb0048 100644 (file)
@@ -2518,8 +2518,8 @@ static int pwrap_probe(struct platform_device *pdev)
                }
        }
 
-       ret = devm_clk_bulk_get_all_enable(wrp->dev, &clk);
-       if (ret)
+       ret = devm_clk_bulk_get_all_enabled(wrp->dev, &clk);
+       if (ret < 0)
                return dev_err_probe(wrp->dev, ret,
                                     "failed to get clocks\n");