]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
bnxt_en: Reserve rings after PCIe AER recovery if NIC interface is down
authorSaravanan Vajravel <saravanan.vajravel@broadcom.com>
Fri, 22 Nov 2024 22:45:41 +0000 (14:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:10 +0000 (19:51 +0100)
[ Upstream commit 5311598f7f3293683cdc761df71ae3469327332c ]

After successful PCIe AER recovery, FW will reset all resource
reservations.  If it is IF_UP, the driver will call bnxt_open() and
all resources will be reserved again.  It it is IF_DOWN, we should
call bnxt_reserve_rings() so that we can reserve resources including
RoCE resources to allow RoCE to resume after AER.  Without this
patch, RoCE fails to resume in this IF_DOWN scenario.

Later, if it becomes IF_UP, bnxt_open() will see that resources have
been reserved and will not reserve again.

Fixes: fb1e6e562b37 ("bnxt_en: Fix AER recovery.")
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index f3c6a122a079a5dad04d1d9613289d05f4bbfe16..127f7d238a041fac0cddf1230bbc22c0d6d28bf8 100644 (file)
@@ -13692,8 +13692,12 @@ static void bnxt_io_resume(struct pci_dev *pdev)
        rtnl_lock();
 
        err = bnxt_hwrm_func_qcaps(bp);
-       if (!err && netif_running(netdev))
-               err = bnxt_open(netdev);
+       if (!err) {
+               if (netif_running(netdev))
+                       err = bnxt_open(netdev);
+               else
+                       err = bnxt_reserve_rings(bp, true);
+       }
 
        bnxt_ulp_start(bp, err);
        if (!err) {