]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ipv6: mcast: Delay put pmc->idev in mld_del_delrec()
authorYue Haibing <yuehaibing@huawei.com>
Mon, 14 Jul 2025 14:19:57 +0000 (22:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Jul 2025 06:53:19 +0000 (08:53 +0200)
[ Upstream commit ae3264a25a4635531264728859dbe9c659fad554 ]

pmc->idev is still used in ip6_mc_clear_src(), so as mld_clear_delrec()
does, the reference should be put after ip6_mc_clear_src() return.

Fixes: 63ed8de4be81 ("mld: add mc_lock for protecting per-interface mld data")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Link: https://patch.msgid.link/20250714141957.3301871-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ipv6/mcast.c

index 9bb246c09fcee82b51648bd54ce447ff2ffc07ef..e153dac47a530d5d7431b865ef288e2baa75870b 100644 (file)
@@ -803,8 +803,8 @@ static void mld_del_delrec(struct inet6_dev *idev, struct ifmcaddr6 *im)
                } else {
                        im->mca_crcount = idev->mc_qrv;
                }
-               in6_dev_put(pmc->idev);
                ip6_mc_clear_src(pmc);
+               in6_dev_put(pmc->idev);
                kfree_rcu(pmc, rcu);
        }
 }