]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: aspeed: Simplify with dev_err_probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 19 Dec 2025 14:31:50 +0000 (15:31 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 21 Dec 2025 12:03:10 +0000 (12:03 +0000)
Use dev_err_probe() to make error code handling simpler and handle
deferred probe nicely (avoid spamming logs).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/aspeed_adc.c

index bf2bfd6bdc412ddcf066a2e3282d469e27406c44..1ae45fe90e6ca7a3289873b4e93180881fb9a6e5 100644 (file)
@@ -535,11 +535,10 @@ static int aspeed_adc_probe(struct platform_device *pdev)
                return PTR_ERR(data->clk_scaler);
 
        data->rst = devm_reset_control_get_shared(&pdev->dev, NULL);
-       if (IS_ERR(data->rst)) {
-               dev_err(&pdev->dev,
-                       "invalid or missing reset controller device tree entry");
-               return PTR_ERR(data->rst);
-       }
+       if (IS_ERR(data->rst))
+               return dev_err_probe(&pdev->dev, PTR_ERR(data->rst),
+                                    "invalid or missing reset controller device tree entry");
+
        reset_control_deassert(data->rst);
 
        ret = devm_add_action_or_reset(data->dev, aspeed_adc_reset_assert,