]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
plugins: fix inclusion of user-mode APIs
authorAlex Bennée <alex.bennee@linaro.org>
Thu, 10 Jul 2025 10:45:28 +0000 (11:45 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Mon, 14 Jul 2025 10:42:49 +0000 (11:42 +0100)
In 903e870f24 (plugins/api: split out binary path/start/end/entry
code) we didn't actually enable the building of the new plugin helper.
However this was missed because only contrib plugins like drcov
actually used the helpers.

With that fixed we discover we also need some more includes to be able
to extract the relevant data from TaskState.

Fixes: 903e870f24 (plugins/api: split out binary path/start/end/entry code)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3014
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-ID: <20250710104531.3099313-6-alex.bennee@linaro.org>

common-user/plugin-api.c.inc
linux-user/meson.build
linux-user/plugin-api.c

index 5b8a1396b6068cc9d8e45b7d3d8392ffc91a7509..63f39832711674f81beb68bd5758416300ddd83b 100644 (file)
@@ -13,6 +13,7 @@
 #include "qemu/osdep.h"
 #include "qemu/main-loop.h"
 #include "qemu/plugin.h"
+#include "accel/tcg/vcpu-state.h"
 #include "qemu.h"
 
 /*
index f47a213ca3dd9a705f24b4b8bef86fafd16b0328..efca8433698fa0163356fb27b47ffc66b4ca1aca 100644 (file)
@@ -27,7 +27,10 @@ linux_user_ss.add(libdw)
 linux_user_ss.add(when: 'TARGET_HAS_BFLT', if_true: files('flatload.c'))
 linux_user_ss.add(when: 'TARGET_I386', if_true: files('vm86.c'))
 linux_user_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING', if_true: files('semihost.c'))
-linux_user_ss.add(when: 'CONFIG_TCG_PLUGINS', if_true: files('plugin-api.c'))
+
+if get_option('plugins')
+  linux_user_ss.add(files('plugin-api.c'))
+endif
 
 syscall_nr_generators = {}
 
index 66755df5263b056c10ea327c238e435ec7fc896f..8d6fbb60e0c566c5ac99e71ece610923c20dcd97 100644 (file)
@@ -12,4 +12,5 @@
 
 #include "qemu/osdep.h"
 #include "qemu.h"
+#include "loader.h"
 #include "common-user/plugin-api.c.inc"