expr: target: Use nft_rule_expr_set_* in the xml parsing code

Code refactoring to use nft_rule_expr_set_* in parse functions

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/expr/target.c b/src/expr/target.c
index 5245ff78de7856d37ae60d8d4cd54f970d650c05..623d22c784bff35d83ef6775ad0718c5196a3815 100644 (file)
--- a/src/expr/target.c
+++ b/src/expr/target.c
@@ -195,7 +195,6 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
                               struct nft_parse_err *err)
 {
 #ifdef XML_PARSING
-       struct nft_expr_target *tg = nft_expr_data(e);
        const char *name;
 
        name = nft_mxml_str_parse(tree, "name", MXML_DESCEND_FIRST,
@@ -203,9 +202,7 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
        if (name == NULL)
                return -1;
 
-       strncpy(tg->name, name, XT_EXTENSION_MAXNAMELEN);
-       tg->name[XT_EXTENSION_MAXNAMELEN-1] = '\0';
-       e->flags |= (1 << NFT_EXPR_TG_NAME);
+       nft_rule_expr_set_str(e, NFT_EXPR_TG_NAME, name);
 
        /* tg->info is ignored until other solution is reached */