]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
gpo: Halt Cert Auto Enroll process if data corrupted
authorDavid Mulder <dmulder@suse.com>
Fri, 6 May 2022 15:46:44 +0000 (09:46 -0600)
committerJeremy Allison <jra@samba.org>
Thu, 12 May 2022 18:45:41 +0000 (18:45 +0000)
If the CA URL cannot be processed, then halt
processing. Otherwise we'll end up in a broken
state later when trying to read from the end
points with missing data.

Signed-off-by: David Mulder <dmulder@suse.com>
Revewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 12 18:45:41 UTC 2022 on sn-devel-184

python/samba/gp_cert_auto_enroll_ext.py

index db85c97fe66f42384a8908c1e080b80070048910..7b604e5065d48f2945defa582f24ef0b3da7414a 100644 (file)
@@ -119,6 +119,7 @@ def obtain_end_point_information(entries):
         elif ca['URL'].lower() != 'ldap:':
             edata = { 'endpoint': ca['URL'] }
             log.error('Failed to parse the endpoint', edata)
+            return {}
     end_point_information = \
         group_and_sort_end_point_information(end_point_information.values())
     return end_point_information