]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
parisc: kernel: replace kfree() with put_device() in create_tree_node()
authorHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Fri, 19 Dec 2025 13:19:26 +0000 (21:19 +0800)
committerHelge Deller <deller@gmx.de>
Fri, 6 Feb 2026 23:45:18 +0000 (00:45 +0100)
If device_register() fails, put_device() is the correct way to
drop the device reference.

Found by code review.

Fixes: 1070c9655b90 ("[PA-RISC] Fix must_check warnings in drivers.c")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: Helge Deller <deller@gmx.de>
arch/parisc/kernel/drivers.c

index 8d23fe42b0cee5535965dab092670e51cdb0cba0..809e3c171ad54144edecde7b2d0253acf9bdb155 100644 (file)
@@ -435,7 +435,7 @@ static struct parisc_device * __init create_tree_node(char id,
        dev->dev.dma_mask = &dev->dma_mask;
        dev->dev.coherent_dma_mask = dev->dma_mask;
        if (device_register(&dev->dev)) {
-               kfree(dev);
+               put_device(&dev->dev);
                return NULL;
        }