[#101,!202] Addressed review comments.

diff --git a/src/bin/dhcp4/tests/config_backend_unittest.cc b/src/bin/dhcp4/tests/config_backend_unittest.cc
index 2e7f674aaea30d31c8d2921fb066c8dd312f6e98..c6a3637d566236031ab509e1a2740f500fbd9b21 100644 (file)
--- a/src/bin/dhcp4/tests/config_backend_unittest.cc
+++ b/src/bin/dhcp4/tests/config_backend_unittest.cc
@@ -74,7 +74,7 @@ protected:
                         }
                     }
 
-                    // Apparently we're looking for on that does not prexist.
+                    // Apparently we're looking for one that does not prexist.
                     return (TestConfigBackendDHCPv4Ptr(new TestConfigBackendDHCPv4(params)));
                 });
     }
@@ -451,6 +451,7 @@ TEST_F(Dhcp4CBTest, DISABLED_mergeOptions) {
 
 // This test verifies that externally configured shared-networks are
 // merged correctly into staging configuration.
+// @todo enable test when SrvConfig can merge shared networks.
 TEST_F(Dhcp4CBTest, DISABLED_mergeSharedNetworks) {
     string base_config =
         "{ \n"

diff --git a/src/lib/cc/tests/stamped_value_unittest.cc b/src/lib/cc/tests/stamped_value_unittest.cc
index ad2581dcba6ce73bbdbb84945dd95e5561c22cf5..869ba4131009301375630d1fd59ae154a44b9d87 100644 (file)
--- a/src/lib/cc/tests/stamped_value_unittest.cc
+++ b/src/lib/cc/tests/stamped_value_unittest.cc
@@ -88,6 +88,14 @@ TEST(StampedValueTest, toElement) {
     ASSERT_THROW(value->toElement(Element::integer), BadValue);
     ASSERT_THROW(value->toElement(Element::real), BadValue);
 
+    // Make sure only lower case "true" and "false" works for Booleans.
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo", "TRUE")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo", "FALSE")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+    ASSERT_NO_THROW(value.reset(new StampedValue("foo","nonsens")));
+    ASSERT_THROW(value->toElement(Element::boolean), BadValue);
+
     // Make sure we can create a DoubleElement.
     ASSERT_NO_THROW(value.reset(new StampedValue("foo", "45.0")));
     ASSERT_NO_THROW(elem = value->toElement(Element::real));