Fix recvbuff code with missing refetch when needing more buffers

bk: 43a8c755zkplXbE41ChrzyX77B9nKA

diff --git a/libntp/recvbuff.c b/libntp/recvbuff.c
index 3985ca365aead3c099f1030e67605581f84d924e..adf6a95bb587c8dc622783de2d3469bc32f100ef 100644 (file)
--- a/libntp/recvbuff.c
+++ b/libntp/recvbuff.c
@@ -153,14 +153,19 @@ get_free_recv_buffer(void)
                if (create_buffers(RECV_INC) <= 0)
                {
                        msyslog(LOG_ERR, "No more memory for recvufs");
+                       UNLOCK();
+                       return (NULL);
+               }
+               buffer = ISC_LIST_HEAD(free_list);
+               if (buffer == NULL)
+               {
+                       msyslog(LOG_ERR, "Failed to obtain more memory for recvbufs");
+                       UNLOCK();
                        return (NULL);
                }
        }
-       else
-       {
-               ISC_LIST_DEQUEUE(free_list, buffer, link);
-               free_recvbufs--;
-       }
+       ISC_LIST_DEQUEUE(free_list, buffer, link);
+       free_recvbufs--;
        UNLOCK();
        return (buffer);
 }