]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
sctp: Use software crc32 checksum when xfrm transform will happen.
authorFan Du <fan.du@windriver.com>
Wed, 16 Oct 2013 02:01:30 +0000 (22:01 -0400)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:53:36 +0000 (07:53 +0200)
[ Upstream commit 27127a82561a2a3ed955ce207048e1b066a80a2a ]

igb/ixgbe have hardware sctp checksum support, when this feature is enabled
and also IPsec is armed to protect sctp traffic, ugly things happened as
xfrm_output checks CHECKSUM_PARTIAL to do checksum operation(sum every thing
up and pack the 16bits result in the checksum field). The result is fail
establishment of sctp communication.

Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Fan Du <fan.du@windriver.com>
Signed-off-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/sctp/output.c

index d494100956af8af2e63a029e39ecd1c638bb9619..8d4eacf8b6da16bc6983ae6a57f6c235ebb0bf46 100644 (file)
@@ -506,7 +506,8 @@ int sctp_packet_transmit(struct sctp_packet *packet)
         * by CRC32-C as described in <draft-ietf-tsvwg-sctpcsum-02.txt>.
         */
        if (!sctp_checksum_disable &&
-           !(dst->dev->features & (NETIF_F_NO_CSUM | NETIF_F_SCTP_CSUM))) {
+           (!(dst->dev->features & (NETIF_F_NO_CSUM | NETIF_F_SCTP_CSUM)) ||
+            (dst_xfrm(dst) != NULL))) {
                __u32 crc32 = sctp_start_cksum((__u8 *)sh, cksum_buf_len);
 
                /* 3) Put the resultant value into the checksum field in the